[Encore] Make @babel/preset-env use polyfills by default #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
weaverryan
approved these changes
Mar 29, 2019
weaverryan
approved these changes
Mar 29, 2019
|
I hijacked this to also talk about |
fabpot
approved these changes
Mar 29, 2019
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to symfony/webpack-encore#545 and must not be merged until a new version of Encore is released (0.26.x).
Quick summary: we will soon set the
useBuiltInsoption of@babel/preset-envtofalseinstead ofentryby default (which makes it not handlecore-jspolyfills anymore).This is needed because the other values (
entryandusage) require the users to at least addcore-jsto their projects and specify its version in@babel/preset-env's settings.With this update the recipe will automatically require
core-js@3and configure@babel/preset-envso polyfills are automatically added when/where they are needed (useBuiltIns: 'usage'andcorejs: 3)./cc @weaverryan