Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match install directions to actual filename for phpstan config file #1556

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

ericpoe
Copy link
Contributor

@ericpoe ericpoe commented Oct 22, 2023

Q A
License MIT
Docs Issue/PR #1555

The file in the repo is phpstan.dist.neon but the text said phpstan.neon.dist.

According to the docs, either phpstan.dist.neon or phpstan.neon.dist are acceptable (see: https://phpstan.org/config-reference#config-file). I'm sticking with phpstan.dist.neon since text editors that recognize the .neon extension will render the contents of the file nicely.

Either `phpstan.dist.neon` or `phpstan.neon.dist` are acceptable (see: https://phpstan.org/config-reference#config-file). I'm sticking with `phpstan.dist.neon` since text editors that recognize the `.neon` extension will render the contents of the file nicely.
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 22, 2023 15:11
@github-actions
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1556/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1556/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'phpstan/phpstan:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Comes from #1540 - thanks!

@symfony-recipes-bot symfony-recipes-bot merged commit fdc3404 into symfony:main Oct 22, 2023
2 checks passed
@ericpoe ericpoe deleted the install-documentation-fix branch October 22, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants