Fix test for autoconfiguration #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the original fix, there were failing tests for I decided to revert the original fix, added a new test for Monolog v3.4.0 and skip the existing and new tests conditionally based on the used Monolog version. There's still one failing test setup (PHP 7.3 with Monolog 2.*), but I think this is not related to the changes in this PR. |
derrabus
approved these changes
Oct 21, 2023
derrabus
force-pushed
the
fix-autoconfiguration-tests
branch
from
49c26d0
to
35b74ea
Compare
|
Thank you @nkl-kst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two small fixes for the Monolog processor autoconfiguration test. The test currently fails because of changes in Seldaek/monolog#1797.
Not sure if I should provide more information. Please let me know if I missed something 馃檪