Add priority field to processor tags #455
Conversation
So that the order in which the processors are used by monolog can be determined.
| foreach ($container->findTaggedServiceIds('monolog.processor') as $id => $tags) { | ||
| foreach ($tags as $tag) { | ||
| if (!empty($tag['channel']) && !empty($tag['handler'])) { | ||
| throw new \InvalidArgumentException(sprintf('you cannot specify both the "handler" and "channel" attributes for the "monolog.processor" tag on service "%s"', $id)); | ||
| if (!isset($tag['priority'])) { |
There was a problem hiding this comment.
Should the priority option also be added to #[AsMonologProcessor] ?
There was a problem hiding this comment.
I should be able to add it without a problem, thanks for the suggestion!
| usort( | ||
| $processors, | ||
| function (array $left, array $right) { | ||
| return $left['tag']['priority'] <=> $right['tag']['priority']; | ||
| } |
There was a problem hiding this comment.
Can the PriorityTaggedServiceTrait be used here?
There was a problem hiding this comment.
Thanks for the suggestion, however the PriorityTaggedServiceTrait can´t be used since it will require some changes because the Trait sorts it ascending (as expected). But monologs pushProcessor actually array_shifts instead of adding it on top of the stack, so I need a descending sort. Which is clarified in the comment.
There was a problem hiding this comment.
We could still use the trait to get the sorted services and reverse the list before adding method calls.
|
Related PR has been merged, can you finish the review @HypeMC? Thanks! |
|
Hey, what's the status here? I'm also interested in the feature. Thanks :) |
Following comment is still open: https://github.com/symfony/monolog-bundle/pull/455/files#r1369858964 |
So that the order in which the processors are used by monolog can be determined.
Example config:
(PR in favor of old PR)