Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias for null handler - fixes #133 #400

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gggeek
Copy link

@gggeek gggeek commented Mar 29, 2021

Fixes #133

@gggeek gggeek changed the title add alias for null handler add alias for null handler - fixes #133 Mar 29, 2021
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests?

In YAML I think you can escape the 'null' to fix solve this, but indeed this is an issue with XML configuration.
I wonder if it worth adding a new specific handler while people can also use the noop handle to achieve almost the same thing..

@gggeek
Copy link
Author

gggeek commented Mar 31, 2021

In YAML I think you can escape the 'null' to fix solve this

True, but it still probably bites many developers the first time that they try to set it up. They might find it easier to use null_handler rather than 'null'

I wonder if it worth adding a new specific handler while people can also use the noop handle to achieve almost the same thing..

I am not sure I get what you mean here... It seems to me that noop handler and null handler behave differently, as the latter is a blackhole sink, while the former is not (truly, making the difference more visible would be welcome). Besides, this is not a new handler, just as easier way to set up an handler which already exists

I'll take a look at tests - but I might need some support with those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use the NullHandler with XML configuration
2 participants