Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Symfony <3 #306

Merged
merged 1 commit into from Jun 11, 2019
Merged

Drop support for Symfony <3 #306

merged 1 commit into from Jun 11, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jun 4, 2019

No description provided.

@stof
Copy link
Member

stof commented Jun 4, 2019

should we make a release with all the existing changes before that ?

composer.json Outdated Show resolved Hide resolved
@lyrixx
Copy link
Member Author

lyrixx commented Jun 4, 2019

I don't know. I initially wanted to merge / close as many issue as possible and then make a release.
Before I cleanup this project, the changelog was broken. So making a release without burden could be possible on the very last commit of master f51d377

But IMHO, it's a bit stupid to do a release, and then to continue to merge new things...

I would go for simplicity: do a release after merge of pending PRs (this one, the one about mailer, and a another couples)

@lyrixx
Copy link
Member Author

lyrixx commented Jun 5, 2019

ping @symfony/deciders

@fabpot
Copy link
Member

fabpot commented Jun 5, 2019

I agree, let's do one release with everything, including the bumps for the deps.

@lyrixx lyrixx merged commit bca34c1 into symfony:master Jun 11, 2019
lyrixx added a commit that referenced this pull request Jun 11, 2019
This PR was merged into the 3.x-dev branch.

Discussion
----------

Drop support for Symfony <3

Commits
-------

bca34c1 Drop support for Symfony <3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants