RedisHandler support #262
RedisHandler support #262
Conversation
| @@ -286,6 +286,13 @@ | |||
| * - host: server log host. ex: 127.0.0.1:9911 | |||
| * - [level]: level name or int value, defaults to DEBUG | |||
| * - [bubble]: bool, defaults to true | |||
| * | |||
| * - redis: | |||
| @@ -699,6 +699,25 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler | |||
| )); | |||
| break; | |||
|
|
|||
| case 'redis': | |||
| if(class_exists('\Redis')){ | |||
There was a problem hiding this comment.
could you check for the id-parameter here?
| @@ -699,6 +699,25 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler | |||
| )); | |||
| break; | |||
|
|
|||
| case 'redis': | |||
| if(class_exists('\Redis')){ | |||
| $client = new Definition('\Redis'); | |||
There was a problem hiding this comment.
could you combine my pullrequest with yours? Then we have a monologHandler for Redis and Predis that works with services as with just redis-host, port, ... etc...
https://github.com/symfony/monolog-bundle/pull/225/files
Then I can close my pullrequest.
|
What needs to be done to get this pr merged? |
|
Hi! Will this be merged in a near future? |
|
+1 |
|
I agree that this should be adjusted to also allow passing a service id for the redis/predis client as per @roelmonnens' comments. If an app already has a redis connection open for other purposes it's kinda silly to open a second one just for the logs. |
|
Also if any of the +1 club wants to take this PR and do the required changes that'd be very helpful. |
|
Closing in favor of #292 |
|
Thanks @LukaszPiechowiak for the initial work |
No description provided.