Allow to display links on created files

[l-vo]

This PR aims to display terminal links on the created file paths when the framework.ide configuration param (or debug.file_link_format container parameter) is set (only displayed if the terminal support it).

[weaverryan]

Hi @l-vo!

Sorry for the slow review. I think this is a really cool idea :). Instead of injecting the FileLinkFormatter and $fileLinkFormat into FileManager, could you create a new service (maybe MakerFileLinkFormatter) that handles this logic? It would also handle all the \033]8;;{$href}\033\\{$text}\033]8;;\033\\ type of stuff. Then we can inject that into FileManager.

Thanks!

[l-vo]

Hi @weaverryan

Sorry for the slow review

No problem :)

I created a new MakerFileLinkFormatter class and I fixed nullable typed arguments (?string) since the bundle is compatible with php 7.0 applications.

[weaverryan]

VERY close now. Could you also add at least one simple test for MakerFileLinkFormatter - just to make sure we don't have a really ugly error in there.

Thanks - I'm looking forward to this!

[l-vo]

Updated 🙂

[weaverryan]

Well-done! A very nice new feature - thank you @l-vo!

[ThomasLandauer]

I was just about to suggest such a feature ;-) However, this kinda means that it's not working for me :-( What's the expected behavior? Since you're saying "only displayed if the terminal support it", which link syntax are you using?

What I would have expected is a clickable link in this line after php bin/console make:migration:

Next: Review the new migration "src/Migrations/Version20211030130836.php"

I committed a similar feature to phpstan and Codeception.

[l-vo]

@ThomasLandauer It's because make:migration rely on doctrine:migrations:diff. So to have a clickable link, the feature must be bring to the doctrine command.

[ThomasLandauer]

@l-vo thanks! However, I just found out that the line I'm talking about is generated here in this bundle at https://github.com/symfony/maker-bundle/blob/main/src/Maker/MakeMigration.php#L129

So what does your PR do then? I tried it with bin/console make:controller, but still getting no link.

[l-vo]

No, look here:

maker-bundle/src/Maker/MakeMigration.php

Line 111 in f76abb1

$migrationOutput = $commandOutput->fetch();

, it's generated by the doctrine:migrations:diff command. Excepted if your terminal is not compatible, it's working for make:controller.