Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working around deprecation errors to get the test suite to pass #259

Merged
merged 1 commit into from Sep 6, 2018
Merged

Working around deprecation errors to get the test suite to pass #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions phpunit.xml.dist
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@
<php>
<ini name="error_reporting" value="-1" />
<env name="TEST_DATABASE_DSN" value="mysql://root:@127.0.0.1:3306/test_maker" />
<!-- See #237 -->
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />
</php>

<testsuites>
Expand Down
9 changes: 9 additions & 0 deletions src/Test/MakerTestEnvironment.php
View file
Open in desktop
Expand Up @@ -338,6 +338,15 @@ private function buildFlexSkeleton()
MakerTestProcess::create('composer require phpunit browser-kit symfony/css-selector', $this->flexPath)
->run();

// temporarily ignoring indirect deprecations - see #237
$replacements = [
[
'filename' => 'phpunit.xml.dist',
'find' => '</php>',
'replace' => ' <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />'."\n".' </php>',
],
];

MakerTestProcess::create('php bin/console cache:clear --no-warmup', $this->flexPath)
->run();
}
Expand Down