Add some native return types

[PhilETaylor]

Symfony version(s) affected

symfony/flex: v1.18.5

Description

Composer version 2.3-dev (2.3-dev+c9baeda95b2da59a8c2d0bb7350b18d009aa891b) 2022-02-21 12:57:32

Symfony Project with symfony/flex: v1.18.5

PHP Fatal error:  Declaration of Symfony\Flex\ParallelDownloader::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []) must be compatible with Composer\Util\RemoteFilesystem::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []): bool in /Users/phil/Sites/example.com/vendor/symfony/flex/src/ParallelDownloader.php on line 132

Fatal error: Declaration of Symfony\Flex\ParallelDownloader::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []) must be compatible with Composer\Util\RemoteFilesystem::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []): bool in /Users/phil/Sites/example.com/vendor/symfony/flex/src/ParallelDownloader.php on line 132

How to reproduce

~/Sites/symfony-test composer -V
Composer version 2.3-dev (2.3-dev+c9baeda95b2da59a8c2d0bb7350b18d009aa891b) 2022-02-21 12:57:32
~/Sites/symfony-test composer selfup --snapshot
You are already using the latest available Composer version c9baeda95b2da59a8c2d0bb7350b18d009aa891b (snapshot channel).
~/Sites/symfony-test composer require symfony/flex 1.18.5
./composer.json has been created
Running composer update symfony/flex
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking symfony/flex (v1.18.5)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing symfony/flex (v1.18.5): Extracting archive
symfony/flex contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "symfony/flex" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?] y
PHP Fatal error:  Declaration of Symfony\Flex\ParallelDownloader::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []) must be compatible with Composer\Util\RemoteFilesystem::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []): bool in /Users/phil/Sites/symfony-test/vendor/symfony/flex/src/ParallelDownloader.php on line 132

Fatal error: Declaration of Symfony\Flex\ParallelDownloader::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []) must be compatible with Composer\Util\RemoteFilesystem::copy($originUrl, $fileUrl, $fileName, $progress = true, $options = []): bool in /Users/phil/Sites/symfony-test/vendor/symfony/flex/src/ParallelDownloader.php on line 132
~/Sites/symfony-test

Possible Solution

:bool ?

Additional Context

I appreciate Im ahead of the game again running bleeding edge composer :)

[PhilETaylor]

Not sure how to fix the unit tests as they seem to be running Locking composer/composer (1.10.x-dev d4b29e9)

[nicolas-grekas]

They are running with both composer 1 and composer 2, which flex supports.

[PhilETaylor]

I suck. The unit tests pass locally, just not in GitHub...

[nicolas-grekas]

You can ignore these warnings!
But there are other failures ;)

[Seldaek]

Thanks for testing snapshots @PhilETaylor ! I reverted the changes as part of composer/composer#10561 because my intent here is to move the Composer code forward as much as I can but not to break things massively..

That said, it's still great if types get added here, so that one day Composer can add them too.

[PhilETaylor]

@Seldaek Hi there... I run snapshot updated daily "for fun" on my Mac. I appreciate it can sometimes be broken - but I do try to contribute when I can, and not complain or look for support on issues. Im not here looking for support but to help.

If I read correctly, this PR is no longer needed because the changes in composer are being reverted?

(I could not resolve the issues anyway, as the unit tests pass locally, but not in the symfony/flex GitHub actions and I ran out of time to debug that - cause probably by my lack of understanding and experience)

[PhilETaylor]

I can confirm using Composer snapshot af995c30384a846a998a4dacb860a02d50400b16 and flex causes no issues so I'll close this for now.

[Seldaek]

@PhilETaylor it's not needed anymore but I think it'd still be nice to add return types so that one day we may add these to Composer too. I didn't want to break all currently installed flex versions right now tho.

So if you do have time to clean up and finalize the PR it'd be cool but if not I can't blame you ;)

[nicolas-grekas]

Thank you @PhilETaylor.