Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Symfony 4.3 #974

Closed
wants to merge 8 commits into from
Closed

Updated to Symfony 4.3 #974

wants to merge 8 commits into from

Conversation

javiereguiluz
Copy link
Member

No description provided.

@@ -21,6 +22,8 @@
</testsuites>

<listeners>
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Thx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config/packages/security.yaml Outdated Show resolved Hide resolved
@@ -1,8 +1,9 @@
security:
encoders:
# Our user class and the algorithm we'll use to encode passwords
# 'auto' means to let Symfony choose the best possible password hasher (Argon2 or Bcrypt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argon2i and bcrypt are deprecated since 4.3
The new 'auto' choice list is sodium or native

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which are themselves using bcrypt or argon2i as algorithm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant the encoder names used for this auto option.

@javiereguiluz javiereguiluz changed the title Updated to Symfony 4.3 Beta 1 Updated to Symfony 4.3 Beta 2 May 25, 2019
@javiereguiluz
Copy link
Member Author

After updating to Symfony 4.3 beta2, I see this deprecation:

image

I can't find any occurrence of for ... if in our templates and the deprecation message doesn't tell us which template contains the error. Any clue? Thanks.

@yceruto
Copy link
Member

yceruto commented May 27, 2019

I guess it comes from the vendor/symfony/swiftmailer-bundle/Resources/views/Collector/swiftmailer.html.twig template.

@yceruto
Copy link
Member

yceruto commented May 27, 2019

I also see another deprecation in tests:

  1x: The "DAMA\DoctrineTestBundle\PHPUnit\PHPUnitListener" class extends "PHPUnit\Framework\BaseTestListener" that is deprecated Use TestListenerDefaultImplementation trait instead.
    1x in DebugClassLoader::loadClass from Symfony\Component\Debug

@yceruto
Copy link
Member

yceruto commented May 27, 2019

I can't find any occurrence of for ... if in our templates and the deprecation message doesn't tell us which template contains the error. Any clue? Thanks.

@javiereguiluz I sent a PR to improve it twigphp/Twig#3031

@fabpot
Copy link
Member

fabpot commented May 28, 2019

Updating SwiftmailerBundle will remove some deprecations.

@javiereguiluz
Copy link
Member Author

I no longer see deprecations after updating Symfony to 4.3 RC1 and the other dependencies too. @yceruto do you still see deprecations in tests? I can't see anything. Thanks.

@yceruto
Copy link
Member

yceruto commented May 28, 2019

@javiereguiluz javiereguiluz changed the title Updated to Symfony 4.3 Beta 2 Updated to Symfony 4.3 May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants