New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to Symfony 4.3 #974
Conversation
@@ -21,6 +22,8 @@ | |||
</testsuites> | |||
|
|||
<listeners> | |||
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know exactly ... but the official recipe includes it: https://github.com/symfony/recipes/blob/3b19bd94886555df1997b441b6cf6a1fab088f3a/symfony/phpunit-bridge/4.1/phpunit.xml.dist#L31
@@ -1,8 +1,9 @@ | |||
security: | |||
encoders: | |||
# Our user class and the algorithm we'll use to encode passwords | |||
# 'auto' means to let Symfony choose the best possible password hasher (Argon2 or Bcrypt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argon2i
and bcrypt
are deprecated since 4.3
The new 'auto' choice list is sodium
or native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which are themselves using bcrypt or argon2i as algorithm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I meant the encoder names used for this auto
option.
I guess it comes from the |
I also see another deprecation in tests:
|
@javiereguiluz I sent a PR to improve it twigphp/Twig#3031 |
Updating SwiftmailerBundle will remove some deprecations. |
I no longer see deprecations after updating Symfony to 4.3 RC1 and the other dependencies too. @yceruto do you still see deprecations in tests? I can't see anything. Thanks. |
I still see this one #974 (comment) https://travis-ci.org/symfony/demo/jobs/538240998#L616 |
No description provided.