Skip to content

Commit

Permalink
Bug 1693000 - Updated CookiePartitionedForeign console message to ref…
Browse files Browse the repository at this point in the history
…er to State Partitioning. r=timhuang,necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D105343
  • Loading branch information
Trikolon committed Feb 16, 2021
1 parent cd3fa8e commit 0379f31
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Expand Up @@ -189,7 +189,7 @@ add_task(async function testForeignCookiePartitionedMessage() {
findMessage(
hud,
`Partitioned cookie or storage access was provided to ${PARTITIONED_URL} because it is ` +
`loaded in the third-party context and storage partitioning is enabled.`
`loaded in the third-party context and dynamic state partitioning is enabled.`
)
);
await testLearnMoreClickOpenNewTab(
Expand Down
Expand Up @@ -17,7 +17,7 @@ const PARTITIONED_URL =

const STORAGE_ISOLATION_GROUP_LABEL =
`Partitioned cookie or storage access was provided to “<URL>” because it is ` +
`loaded in the third-party context and storage partitioning is enabled.`;
`loaded in the third-party context and dynamic state partitioning is enabled.`;

const COOKIE_BEHAVIOR_PREF = "network.cookie.cookieBehavior";
const COOKIE_BEHAVIOR_PARTITION_FOREIGN = 5;
Expand Down
4 changes: 2 additions & 2 deletions netwerk/locales/en-US/necko.properties
Expand Up @@ -37,10 +37,10 @@ CookieBlockedByPermission=Request to access cookies or storage on “%1$S” was
CookieBlockedTracker=Request to access cookie or storage on “%1$S” was blocked because it came from a tracker and content blocking is enabled.
CookieBlockedAll=Request to access cookie or storage on “%1$S” was blocked because we are blocking all storage access requests.
CookieBlockedForeign=Request to access cookie or storage on “%1$S” was blocked because we are blocking all third-party storage access requests and content blocking is enabled.
# As part of dynamic first-party isolation, third-party resources might be limited to "partitioned" storage access that is separate from the first-party context.
# As part of dynamic state partitioning, third-party resources might be limited to "partitioned" storage access that is separate from the first-party context.
# This allows e.g. cookies to still be set, and prevents tracking without totally blocking storage access. This message is shown in the web console when this happens
# to inform developers that their storage is isolated.
CookiePartitionedForeign=Partitioned cookie or storage access was provided to “%1$S” because it is loaded in the third-party context and storage partitioning is enabled.
CookiePartitionedForeign2=Partitioned cookie or storage access was provided to “%1$S” because it is loaded in the third-party context and dynamic state partitioning is enabled.

# LOCALIZATION NOTE (CookieAllowedForOriginByStorageAccessAPI): %2$S and %1$S are URLs.
CookieAllowedForOriginByStorageAccessAPI=Storage access granted for origin “%2$S” on “%1$S”.
Expand Down
Expand Up @@ -171,7 +171,7 @@ void ReportBlockingToConsole(uint64_t aWindowID, nsIURI* aURI,

case uint32_t(
nsIWebProgressListener::STATE_COOKIES_PARTITIONED_FOREIGN):
message = "CookiePartitionedForeign";
message = "CookiePartitionedForeign2";
category = "cookiePartitionedForeign"_ns;
break;

Expand Down

0 comments on commit 0379f31

Please sign in to comment.