Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singularity.conf: Add allow uts ns option #2915

Merged
merged 3 commits into from May 14, 2024
Merged

singularity.conf: Add allow uts ns option #2915

merged 3 commits into from May 14, 2024

Conversation

cyanezstange
Copy link
Contributor

Description of the Pull Request (PR):

singularity.conf now accepts setting the allow uts ns option, and can
invalidate the use of the --uts and --hostname flags.

This fixes or addresses the following GitHub issues:

@cyanezstange cyanezstange requested a review from dtrudg May 13, 2024 15:06
dtrudg
dtrudg requested changes May 13, 2024
View reviewed changes
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - a couple of minor things that aren't related to the functionality.

CHANGELOG.md Outdated Show resolved Hide resolved
internal/pkg/runtime/engine/singularity/prepare_linux.go Outdated Show resolved Hide resolved
e2e/config/config.go Outdated Show resolved Hide resolved
@dtrudg dtrudg changed the title Issue1767 singularity.conf: Add allow uts ns option May 13, 2024
@cyanezstange cyanezstange marked this pull request as ready for review May 14, 2024 03:25
@cyanezstange cyanezstange requested a review from dtrudg May 14, 2024 03:26
dtrudg
dtrudg approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanezstange cyanezstange merged commit 7ac9484 into sylabs:main May 14, 2024
1 check passed
@cyanezstange cyanezstange deleted the issue1767 branch May 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrudg dtrudg dtrudg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable --uts option in singularity.conf
2 participants
@cyanezstange @dtrudg