This repository has been archived by the owner on Mar 31, 2024. It is now read-only.
Generate completions for each multicall binary #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
force-pushed
the
generate-completions-for-each-multicall-binary
branch
2 times, most recently
from
4192672
to
15617cc
Compare
swsnr
force-pushed
the
generate-completions-for-each-multicall-binary
branch
from
15617cc
to
8f9e830
Compare
We used to generate completions for the top-level command, but that's
not correct in a multicall binary: It includes the subcommands as
completable arguments, whereas we actually need to split completions per
subcommand.
Hence, iterate over the two relevant subcommands aka binary names, and
separately generate the completion for each corresponding subcommand.
This corrects completions for mdcat, and as a bonus we now also generate
completions for mdless which we didn't have before.
Closes GH-214
swsnr
force-pushed
the
generate-completions-for-each-multicall-binary
branch
from
8f9e830
to
1c41114
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes completions for
mdcatand additional generates completions formdless.Closes GH-214