Use embedded bindings on Windows #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
swsnr
requested changes
May 11, 2023
|
@Jake-Shadle I'd also appreciate if you'd sign your commit. Thanks 🙏🏿 |
|
Uhh, I guess I'll resubmit it in the UI or something, have never done signed commits locally. |
|
You can just use SSH (same key you're using to push), but never mind. I'll merge it anyway. Changelog would be nice though 😇 |
|
@Jake-Shadle Thanks 🙏🏿 I'll make a new release with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The giant
windowscrate was being pulled in for a single function, which is kind of wasteful, this just embeds the one function binding and one constant binding.This reduces compile time by ~1s which was not the biggest deal, the problem is more that the dependency was massive overkill generally (ie it expands to ~172MiB of source code when the crate tarball is unpacked).