fix(web-styles): publish the `dist` subdirectory #152

driimus · 2022-06-29T10:37:17Z

Fixes the release workflow, which currently fails for the web-styles package because the publish command targets the dist folder, and dist/package.json points to /dist/dist, a directory that doesn't exist. Haven't looked into why looking for a package.json file in dist/dist doesn't produce an error, but transforming dist/package.json should fix the issue.

I have tried it out locally against verdaccio and changeset publish worked as expected. Feel free to close the PR if you have different plans for fixing the issue, I'm more interested in letting you know what went wrong.

Why only `web-styles`?

Not 100% sure as to why swisspost-intranet-header doesn't have the same issue, but my guess is:
https://github.com/swisspost/common-web-frontend/blob/9203419db831f4eca3fca92b3f6b55194e0701e4/packages/angular-components/projects/swisspost-intranet-header/package.json#L9
When the publish command runs in dist/swisspost-intranet-header, it will end up pointing to the current directory, meaning that the relative path ends up being correct.

Context

I had a similar issue as the one described in changesets/action#191 (in my case, the failure was TypeScript compilation errors).

The difference is that mine would be fixable by changesets/changesets#844, because pnpm does redirect compilation errors to stdout by default (can be overridden by use-stderr in .npmrc).

changeset-bot · 2022-06-29T10:37:22Z

⚠️ No Changeset found

Latest commit: 1f2f264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gfellerph · 2022-07-01T10:00:35Z

@driimus absolutely amazing, thank you so much for taking the time to investigate and fix the issue. Also, you are our first external contributor. Please accept my humble offering of 💯 fake internet points.

We're planning to improve the web-styles situation with #143, but until then, I'm glad to try your fix.