Get rid of vulnerable gulp-sass/node-sass/node-gyp #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limonte
force-pushed
the
chore/get-rid-of-gulp-sass-node-sass-node-gyp
branch
from
8bb39ba
to
f14105d
Compare
limonte
force-pushed
the
chore/get-rid-of-gulp-sass-node-sass-node-gyp
branch
from
f14105d
to
8e6fb12
Compare
|
Code Climate has analyzed commit 8e6fb12 and detected 0 issues on this pull request. View more on Code Climate. |
Pull Request Test Coverage Report for Build 4899
💛 - Coveralls |
|
🎉 This PR is included in version 8.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-gypis vulnerable and doesn't seem to be well-maintainedLet's get rid of
gulp-sass -> node-sass -> node-gypand replace them with simplesass.Related to dlmanning/gulp-sass#730 and sass/node-sass#2625