test(swc): Add Bazel tests #6933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtimetodie
force-pushed
the
bazel-test
branch
2 times, most recently
from
e5eb214
to
128faf5
Compare
kdy1
previously approved these changes
Feb 11, 2023
|
Oh CI failed |
|
This can only be merged after #6930. |
swc-bot
reviewed
Feb 11, 2023
auto-merge was automatically disabled
February 11, 2023 18:40
Head branch was pushed to by a user without write access
realtimetodie
force-pushed
the
bazel-test
branch
from
a44cf1e
to
5dfd118
Compare
kdy1
requested changes
Feb 13, 2023
| panic!("Failed to create symbolic link"); | ||
| }; | ||
|
|
||
| return (); |
| let _ = remove_file(symlink_build_path.clone()); | ||
|
|
||
| let symlink_source_path = src_dir.join("modules"); | ||
| let _ = remove_file(symlink_source_path.clone()); |
| let _ = remove_file(symlink_build_path.clone()); | ||
|
|
||
| let symlink_source_path = src_dir.join("modules"); | ||
| let _ = remove_file(symlink_source_path.clone()); |
There was a problem hiding this comment.
Suggested change
| let _ = remove_file(symlink_source_path.clone()); | |
| let _ = remove_file(&symlink_source_path); |
| let modules_dir = test_dir.join("modules"); | ||
|
|
||
| let symlink_build_path = test_dir.join("build"); | ||
| let _ = remove_file(symlink_build_path.clone()); |
There was a problem hiding this comment.
Suggested change
| let _ = remove_file(symlink_build_path.clone()); | |
| let _ = remove_file(&symlink_build_path); |
|
|
||
| #[cfg(target_family = "unix")] | ||
| { | ||
| symlink(src_dir, symlink_build_path.clone()).unwrap(); |
| #[cfg(target_family = "unix")] | ||
| { | ||
| symlink(src_dir, symlink_build_path.clone()).unwrap(); | ||
| symlink(modules_dir, symlink_source_path).unwrap(); |
| // unprivileged users. | ||
| #[cfg(target_os = "windows")] | ||
| { | ||
| symlink_dir(src_dir.clone(), symlink_build_path.clone()).unwrap_or_else(|_| { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration test that simulates a Bazel environment using symbolic links to sources.
Related
jsc.pathson Windows #6930