Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Make name mangler respect toplevel #6774

Merged
merged 22 commits into from Jan 10, 2023
Merged

fix(es/minifier): Make name mangler respect toplevel #6774

merged 22 commits into from Jan 10, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 10, 2023 •
edited

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 10, 2023
@kdy1 kdy1 self-assigned this Jan 10, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Respect toplevel fix(es/minifier): Make name mangler respect toplevel Jan 10, 2023
kdy1
kdy1 commented Jan 10, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier --breaking

@kdy1 kdy1 marked this pull request as ready for review January 10, 2023 04:53
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 10, 2023 04:53
@kdy1 kdy1 disabled auto-merge January 10, 2023 04:59
@kdy1 kdy1 requested a review from jridgewell January 10, 2023 05:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
View reviewed changes
jridgewell
jridgewell previously approved these changes Jan 10, 2023
View reviewed changes
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via 1f3236b January 10, 2023 05:39
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 10, 2023 05:40
swc-bot
swc-bot reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit ec7e913 into swc-project:main Jan 10, 2023
@kdy1 kdy1 deleted the minifier-top branch January 10, 2023 06:42
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.26
Development

Successfully merging this pull request may close these issues.

Minifier does not respect toplevel: false
3 participants
@kdy1 @jridgewell @swc-bot