Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es): Preserve license comments by default #6703

Merged
merged 2 commits into from Dec 21, 2022
Merged

fix(es): Preserve license comments by default #6703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5517f
change default
kdy1 Dec 21, 2022
7300188
Merge branch 'main' into default
swc-bot Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/swc/src/config/mod.rs
View file
Open in desktop
Expand Up @@ -943,7 +943,7 @@ pub struct JsMinifyFormatOptions {
#[serde(default)]
pub braces: bool,

#[serde(default)]
#[serde(default = "default_comments")]
pub comments: BoolOrDataConfig<JsMinifyCommentOption>,

/// Not implemented yet.
Expand Down Expand Up @@ -1015,6 +1015,10 @@ pub struct JsMinifyFormatOptions {
pub wrap_func_args: bool,
}

fn default_comments() -> BoolOrDataConfig<JsMinifyCommentOption> {
BoolOrDataConfig::from_obj(JsMinifyCommentOption::PreserveSomeComments)
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub enum JsMinifyCommentOption {
#[serde(rename = "some")]
Expand Down