Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): Add contexts to the error messages #6526

Merged
merged 24 commits into from Nov 28, 2022
Merged

feat(common): Add contexts to the error messages #6526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ad09cd3
example
kdy1 Nov 28, 2022
ccf1c1d
context lines
kdy1 Nov 28, 2022
e7bace7
with_context_lines
kdy1 Nov 28, 2022
3650f22
We should not ignore these
kdy1 Nov 28, 2022
aa3793a
Fix `read_span`
kdy1 Nov 28, 2022
5e1b49a
fixup
kdy1 Nov 28, 2022
f3cf2e7
Fix
kdy1 Nov 28, 2022
73ea6c4
Update test refs
kdy1 Nov 28, 2022
e544bc1
Fix
kdy1 Nov 28, 2022
2e58203
cspell
kdy1 Nov 28, 2022
75c438c
trim
kdy1 Nov 28, 2022
573c0a5
Update test refs
kdy1 Nov 28, 2022
a8f018b
Update test refs
kdy1 Nov 28, 2022
942af3f
Update test refs
kdy1 Nov 28, 2022
6a57ac8
Fix lo
kdy1 Nov 28, 2022
b8ffedc
Update test refs
kdy1 Nov 28, 2022
6da9341
+1
kdy1 Nov 28, 2022
44cf12e
Update test refs
kdy1 Nov 28, 2022
9ee9210
Update test refs
kdy1 Nov 28, 2022
c6fe127
Fix again
kdy1 Nov 28, 2022
a275fd6
Update test refs
kdy1 Nov 28, 2022
3a873f6
Update test refs
kdy1 Nov 28, 2022
ce727d7
Update test refs
kdy1 Nov 28, 2022
57552da
Pin
kdy1 Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
254 changes: 172 additions & 82 deletions crates/swc/tests/errors/lints/const-assign/1/output.swc-stderr
View file
Open in desktop

Large diffs are not rendered by default.

151 changes: 114 additions & 37 deletions crates/swc/tests/errors/lints/const-assign/2/output.swc-stderr
View file
Open in desktop
Expand Up @@ -9,48 +9,62 @@
4 |
5 | foo = 1;
: ^^^
`----

x cannot reassign to an imported binding
,-[2:1]
2 | import bar from "bar";
: ^|^
: `-- imported binding
3 | import * as baz from "baz";
4 |
5 | foo = 1;
6 | bar = 2;
: ^^^
`----

x cannot reassign to an imported binding
,-[3:1]
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
4 |
5 | foo = 1;
6 | bar = 2;
7 | baz = 3;
: ^^^
`----

x cannot reassign to an imported binding
,-[1:1]
1 | import { foo } from "foo";
: ^|^
: `-- imported binding
2 | import bar from "bar";
: ^|^
: `-- imported binding
3 | import * as baz from "baz";
4 |
5 | foo = 1;
6 | bar = 2;
: ^^^
7 | baz = 3;
8 |
9 | foo++;
: ^^^
`----

x cannot reassign to an imported binding
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
4 |
5 | foo = 1;
6 | bar = 2;
7 | baz = 3;
: ^^^
8 |
9 | foo++;
10 | foo--;
`----

x cannot reassign to an imported binding
,-[1:1]
1 | import { foo } from "foo";
: ^|^
: `-- imported binding
2 | import bar from "bar";
3 | import * as baz from "baz";
4 |
5 | foo = 1;
6 | bar = 2;
7 | baz = 3;
8 |
9 | foo++;
: ^^^
10 | foo--;
11 |
12 | ++bar;
`----

x cannot reassign to an imported binding
,-[1:1]
1 | import { foo } from "foo";
Expand All @@ -66,10 +80,14 @@
9 | foo++;
10 | foo--;
: ^^^
11 |
12 | ++bar;
13 | --bar;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand All @@ -84,10 +102,13 @@
11 |
12 | ++bar;
: ^^^
13 | --bar;
14 |
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand All @@ -103,6 +124,9 @@
12 | ++bar;
13 | --bar;
: ^^^
14 |
15 |
16 | foo += 10;
`----

x cannot reassign to an imported binding
Expand All @@ -126,10 +150,14 @@
15 |
16 | foo += 10;
: ^^^
17 | bar -= 10;
18 | baz *= 10;
19 | foo /= 10;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand All @@ -149,10 +177,15 @@
16 | foo += 10;
17 | bar -= 10;
: ^^^
18 | baz *= 10;
19 | foo /= 10;
20 | bar %= 10;
`----

x cannot reassign to an imported binding
,-[3:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
Expand All @@ -172,6 +205,8 @@
17 | bar -= 10;
18 | baz *= 10;
: ^^^
19 | foo /= 10;
20 | bar %= 10;
`----

x cannot reassign to an imported binding
Expand All @@ -198,10 +233,14 @@
18 | baz *= 10;
19 | foo /= 10;
: ^^^
20 | bar %= 10;
21 |
22 | baz <<= 10;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand All @@ -224,10 +263,15 @@
19 | foo /= 10;
20 | bar %= 10;
: ^^^
21 |
22 | baz <<= 10;
23 | foo >>= 10;
`----

x cannot reassign to an imported binding
,-[3:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
Expand All @@ -251,6 +295,9 @@
21 |
22 | baz <<= 10;
: ^^^
23 | foo >>= 10;
24 |
25 | bar >>>= 10;
`----

x cannot reassign to an imported binding
Expand Down Expand Up @@ -281,10 +328,13 @@
22 | baz <<= 10;
23 | foo >>= 10;
: ^^^
24 |
25 | bar >>>= 10;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand Down Expand Up @@ -312,10 +362,15 @@
24 |
25 | bar >>>= 10;
: ^^^
26 |
27 | baz |= 10;
28 | foo ^= 10;
`----

x cannot reassign to an imported binding
,-[3:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
Expand Down Expand Up @@ -344,6 +399,9 @@
26 |
27 | baz |= 10;
: ^^^
28 | foo ^= 10;
29 | bar &= 10;
30 | baz **= 10;
`----

x cannot reassign to an imported binding
Expand Down Expand Up @@ -379,10 +437,13 @@
27 | baz |= 10;
28 | foo ^= 10;
: ^^^
29 | bar &= 10;
30 | baz **= 10;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand Down Expand Up @@ -414,10 +475,15 @@
28 | foo ^= 10;
29 | bar &= 10;
: ^^^
30 | baz **= 10;
31 |
32 | foo &&= 10;
`----

x cannot reassign to an imported binding
,-[3:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
Expand Down Expand Up @@ -449,6 +515,9 @@
29 | bar &= 10;
30 | baz **= 10;
: ^^^
31 |
32 | foo &&= 10;
33 | bar ||= 10;
`----

x cannot reassign to an imported binding
Expand Down Expand Up @@ -488,10 +557,14 @@
31 |
32 | foo &&= 10;
: ^^^
33 | bar ||= 10;
34 |
35 | baz ??= 10;
`----

x cannot reassign to an imported binding
,-[2:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
: ^|^
: `-- imported binding
Expand Down Expand Up @@ -527,10 +600,14 @@
32 | foo &&= 10;
33 | bar ||= 10;
: ^^^
34 |
35 | baz ??= 10;
`----

x cannot reassign to an imported binding
,-[3:1]
,-[1:1]
1 | import { foo } from "foo";
2 | import bar from "bar";
3 | import * as baz from "baz";
: ^|^
: `-- imported binding
Expand Down