Upgrade browserslist-rs
#6488
Closed
Upgrade browserslist-rs
#6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importantly, `browserslist-rs` v0.12 marked Internet Explorer as dead: https://github.com/browserslist/browserslist-rs/releases/tag/v0.12.0
|
|
|
|
kwonoj
requested changes
Nov 21, 2022
There was a problem hiding this comment.
We need browserslist/browserslist-rs#13 change before upgrading brwoserslists-rs.
|
/cc @g-plane for the visibility. |
|
Closes as this is fixed by #6547 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Upgrades the
browserslist-rsdependency.Importantly,
browserslist-rsv0.12 marked Internet Explorer as dead:https://github.com/browserslist/browserslist-rs/releases/tag/v0.12.0
BREAKING CHANGE:
Not sure if this is a breaking change, because browserslist queries are supposed to have different results over time. Most likely this PR could be considered a bug fix, because people expect the browserslist query to match the current spec and behavior.
Related issue (if exists):
N/A.