Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Preserve parentheses for new expr in optional chaining #6484

Merged
merged 3 commits into from Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
72 changes: 72 additions & 0 deletions crates/swc/tests/fixture/issues-6xxx/6438/input/.swcrc
@@ -0,0 +1,72 @@
{
"jsc": {
"parser": {
"syntax": "typescript",
"tsx": true
},
"transform": {
"react": {
"runtime": "automatic",
"importSource": "preact",
"development": true
}
},
"target": "es2022",
"loose": false,
"minify": {
"compress": {
"arguments": false,
"arrows": true,
"booleans": true,
"booleans_as_integers": false,
"collapse_vars": true,
"comparisons": true,
"computed_props": true,
"conditionals": true,
"dead_code": true,
"directives": true,
"drop_console": false,
"drop_debugger": true,
"evaluate": true,
"expression": false,
"hoist_funs": false,
"hoist_props": true,
"hoist_vars": false,
"if_return": true,
"join_vars": true,
"keep_classnames": false,
"keep_fargs": true,
"keep_fnames": false,
"keep_infinity": false,
"loops": true,
"negate_iife": true,
"properties": true,
"reduce_funcs": false,
"reduce_vars": false,
"side_effects": true,
"switches": true,
"typeofs": true,
"unsafe": false,
"unsafe_arrows": false,
"unsafe_comps": false,
"unsafe_Function": false,
"unsafe_math": false,
"unsafe_symbols": false,
"unsafe_methods": false,
"unsafe_proto": false,
"unsafe_regexp": false,
"unsafe_undefined": false,
"unused": true,
"const_to_let": true,
"pristine_globals": true,
"passes": 2
},
"mangle": false
}
},
"module": {
"type": "es6"
},
"minify": true,
"isModule": true
}
1 change: 1 addition & 0 deletions crates/swc/tests/fixture/issues-6xxx/6438/input/index.js
@@ -0,0 +1 @@
new Date()?.toLocaleDateString()
@@ -0,0 +1 @@
new Date()?.toLocaleDateString();
13 changes: 7 additions & 6 deletions crates/swc_ecma_codegen/src/lib.rs
Expand Up @@ -810,7 +810,11 @@ where

match n.base {
OptChainBase::Member(ref e) => {
emit!(e.obj);
if let Expr::New(new) = &*e.obj {
self.emit_new(new, false)?;
} else {
emit!(e.obj);
}
punct!("?.");

match &e.prop {
Expand All @@ -820,11 +824,8 @@ where
}
}
OptChainBase::Call(ref e) => {
if let Expr::New(new) = &*e.callee {
self.emit_new(new, false)?;
} else {
emit!(e.callee);
}
debug_assert!(!e.callee.is_new());
emit!(e.callee);
kdy1 marked this conversation as resolved.
Show resolved Hide resolved
punct!("?.");

punct!("(");
Expand Down