fix(es/compat): Fix handling of deep array pattern of object rest pass

crates/swc/tests/exec.rs

@@ -151,7 +151,8 @@ fn create_matrix(entry: &Path) -> Vec<Options> {
                     jsc: JscConfig {
                         syntax: Some(syntax),
                         transform: None.into(),
-                        external_helpers: external_helpers.into(),
+                        // true, false
+                        external_helpers: (!external_helpers).into(),
                         target: Some(target),
                         minify: if minify {
                             Some(JsMinifyOptions {

crates/swc/tests/exec/issues-6xxx/6029/exec.js

@@ -0,0 +1,8 @@
+
+
+function thing({ queryKey: [{ url, ...query }] }) {
+    console.log(url);
+    console.log(query);
+}
+
+thing({ queryKey: [{ url: 'https://www.google.com', id: '1' }] })

crates/swc_ecma_transforms_compat/src/es2018/object_rest_spread.rs

@@ -784,7 +784,7 @@ impl ObjectRest {
                         // TODO: fix this. this is wrong
                         obj.clone(),
                         use_expr_for_assign,
-                        use_member_for_array,
+                        true,
                     );
                     ObjectPatProp::Rest(RestPat {
                         dot3_token,
@@ -873,7 +873,7 @@ impl ObjectRest {
                                 .into(),
                             ),
                             use_expr_for_assign,
-                            use_member_for_array,
+                            true,
                         ),
                     );
                     ObjectPatProp::KeyValue(KeyValuePatProp { key, value })

crates/swc_ecma_transforms_compat/tests/es2018_object_rest_spread.rs

@@ -1,7 +1,8 @@
-use swc_common::chain;
+use swc_common::{chain, Mark};
 use swc_ecma_parser::Syntax;
+use swc_ecma_transforms_base::resolver;
 use swc_ecma_transforms_compat::{
-    es2015::spread,
+    es2015::{self, spread},
     es2018::{object_rest_spread, object_rest_spread::Config},
 };
 use swc_ecma_transforms_testing::{test, test_exec};
@@ -3101,3 +3102,44 @@ a.c;a.c;
 expect(counter).toEqual(2);
 "#
 );
+
+test_exec!(
+    syntax(),
+    |_| tr(Default::default()),
+    issue_6029_1,
+    r#"
+  function thing({ queryKey: [{ url, ...query }] }) {
+      expect(url).toEqual('https://www.google.com')
+      expect(query).toEqual({ id: '1' })
+  }
+
+  thing({ queryKey: [{ url: 'https://www.google.com', id: '1' }] })
+  "#
+);
+
+test_exec!(
+    syntax(),
+    |t| {
+        //
+        let unresolved_mark = Mark::new();
+        let top_level_mark = Mark::new();
+        chain!(
+            resolver(unresolved_mark, top_level_mark, false),
+            tr(Default::default()),
+            es2015::es2015(
+                unresolved_mark,
+                Some(t.comments.clone()),
+                Default::default()
+            ),
+        )
+    },
+    issue_6029_2,
+    r#"
+    function thing({ queryKey: [{ url, ...query }] }) {
+        expect(url).toEqual('https://www.google.com')
+        expect(query).toEqual({ id: '1' })
+    }
+
+    thing({ queryKey: [{ url: 'https://www.google.com', id: '1' }] })
+    "#
+);