Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Update defaults #4300

Closed
wants to merge 8 commits into from
Closed

feat(es/minifier): Update defaults #4300

wants to merge 8 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 10, 2022

Description:

Related issue (if exists):

@kdy1
Copy link
Member Author

kdy1 commented Apr 10, 2022 •
edited

cc @Austaras Seems like terser tests are still passing.

(It's not updated)

image

@kdy1
Copy link
Member Author

kdy1 commented Apr 10, 2022

Oh there was some regressions

kdy1
kdy1 commented Apr 10, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier --breaking

@Austaras
Copy link
Member

Do crates/swc_ecma_minifier/src/option/mod.rs need update too?

@kdy1
Copy link
Member Author

kdy1 commented Apr 11, 2022

Oh I think so, thanks!

@kdy1
Copy link
Member Author

kdy1 commented Apr 11, 2022

I think we should enable rules on by one. (Because of bugs)
Closing, and I updated #2934

@kdy1 kdy1 closed this Apr 11, 2022
@kdy1 kdy1 deleted the minifier-3 branch April 11, 2022 07:21
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @Austaras