Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): switches #4260

Merged
merged 28 commits into from Apr 21, 2022
Merged

feat(es/minifier): switches #4260

merged 28 commits into from Apr 21, 2022

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Apr 6, 2022 •
edited

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1
Copy link
Member

kdy1 commented Apr 6, 2022

FYI, defaults is the same as terser

@Austaras
Copy link
Member Author

Austaras commented Apr 6, 2022

terser enables switches by default

@Austaras Austaras force-pushed the switch branch 2 times, most recently from af8a9fe to 86fec88 Compare April 7, 2022 04:08
@Austaras Austaras mentioned this pull request Apr 10, 2022
Merged
@Austaras Austaras force-pushed the switch branch 6 times, most recently from 1d1a1b8 to d859b4c Compare April 17, 2022 08:46
@Austaras Austaras force-pushed the switch branch 7 times, most recently from 539a779 to baf2c1c Compare April 20, 2022 06:24
@Austaras Austaras force-pushed the switch branch 5 times, most recently from f152ac9 to e1358f9 Compare April 20, 2022 09:19
@kdy1 kdy1 mentioned this pull request Apr 20, 2022
Closed
Austaras
Austaras commented Apr 20, 2022
View reviewed changes
crates/swc_ecma_minifier/tests/terser/compress/switch/gut_entire_switch/output.js Outdated
@@ -1,2 +1 @@
id(123);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug of dead_branch_remover

kdy1
kdy1 requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This is not approval, just to prevent forgetting a version bump

swc-bump:

  • swc_ecma_utils --breaking

crates/swc_ecma_utils/src/lib.rs Outdated Show resolved Hide resolved
kdy1
kdy1 requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I reviewed tests and those look good. I have some concern about future debugging (mainly infinite loop)

crates/swc_ecma_minifier/src/compress/optimize/switches.rs Show resolved Hide resolved
crates/swc_ecma_minifier/src/compress/optimize/mod.rs Outdated Show resolved Hide resolved
crates/swc_ecma_minifier/src/compress/optimize/switches.rs Outdated Show resolved Hide resolved
kdy1
kdy1 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) April 21, 2022 09:43
@kdy1 kdy1 added this to the Planned milestone Apr 21, 2022
@kdy1 kdy1 merged commit 8cf3ddd into swc-project:main Apr 21, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.2.171 Apr 21, 2022
@Austaras Austaras deleted the switch branch April 22, 2022 05:51
@smvv smvv mentioned this pull request Apr 23, 2022
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.171
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Austaras @kdy1