Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecma/transform/compat): arrow parameters in class field #3556

Merged
merged 1 commit into from Feb 14, 2022
Merged

fix(ecma/transform/compat): arrow parameters in class field #3556

merged 1 commit into from Feb 14, 2022

Conversation

Austaras
Copy link
Member

Related issue (if exists):
closes #3471

kdy1
kdy1 requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think we may change the pass ordering

crates/swc_ecma_transforms_compat/src/es2015/parameters.rs Show resolved Hide resolved
@kdy1 kdy1 added this to the v1.2.140 milestone Feb 14, 2022
@kdy1 kdy1 merged commit 45b44b0 into swc-project:main Feb 14, 2022
@Austaras Austaras deleted the arrow branch February 14, 2022 06:46
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.140
Development

Successfully merging this pull request may close these issues.

Arrow functions as class properties compile incorrectly
2 participants
@Austaras @kdy1