fix(swc): Remove import statement canonicalization

[realtimetodie]

Fixes an issue where import statements to symbolic links (symlinks) are canonicalized in generated code and use the absolute form of the path with all intermediate components normalized and symbolic links resolved.

Import resolution was introduced in #1834.

However, resolving symbolic links in generated code is unnecessary. A JavaScript runtime (Node.js, Deno) will resolve import statements to symbolic links at runtime.

The suggested solution introduces a new match guard to determine whether the path is relative and uses the current working directory as a base path. For example, the current working directory is already used as a base path for module resolution

swc/crates/swc_ecma_transforms_module/src/path.rs

Line 276 in 072bd13

std::env::current_dir()?.join(path)

Actual behavior (generated code, canonicalized import statement from a symbolic link)

const a = require("../../../src/modules/a");

Expected behavior

const a = require("./modules/a");

Related

• import statements improperly transformed when using symlinks #4057
• Update SWC to re-enable sandbox aspect-build/rules_swc#61
• Run bare rust CLI binary, no node aspect-build/rules_swc#88

[realtimetodie]

The tests are failing with the same error message. I am not sure how to handle this.

@kwonoj

Error("unknown field `chrome-android`, expected one of `chrome`, `and_chr`, `and_ff`, `op_mob`, `ie`, `edge`,
 `firefox`, `safari`, `node`, `ios`, `samsung`, `opera`, `android`, `electron`, `phantom`, `opera_mobile`, `rhino`, 
 `deno`, `hermes`, `oculus`, `bun`", line: 6, column: 20)', crates/swc_ecma_preset_env/src/corejs3/compat.rs:10:10

[kdy1]

I'll fix CI with another PR

[realtimetodie]

Rebased with main

[kdy1]

Thank you!

---

swc-bump:

• swc

[kdy1]

I'm considering reverting this because of #6782.
Do you think this PR fixes any real issues?

[kdy1]

I added reverting commit to #6930

[realtimetodie]

Why was this reverted? @kdy1

This breaks rules_swc @alexeagle

[kdy1]

Because this PR is breaking a valid app and there's no test case in this PR