Skip to content

Commit

Permalink
fix(es/modules): Remove wrong check for jsc.paths (#6470)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #6466.
  • Loading branch information
@kdy1
kdy1 committed Nov 18, 2022
1 parent e8b0b1c commit 072bd13
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
8 changes: 6 additions & 2 deletions crates/swc_ecma_transforms_module/src/path.rs
View file
Expand Up @@ -121,13 +121,17 @@ where

if let Some(orig_ext) = orig_ext {
let use_orig = if let Some(ext) = p.extension() {
(ext == "ts" || ext == "tsx") && p.is_file()
ext == "ts" || ext == "tsx"
} else {
false
};

if use_orig {
p.set_extension(orig_ext);
if matches!(orig_ext, "js" | "mjs" | "cjs" | "jsx") {
p.set_extension(orig_ext);
} else {
p.set_extension("");
}
}
} else {
p.set_extension("");
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4532/output/index.ts
View file
@@ -1 +1 @@
import "./rel.ts";
import "./rel.js";
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4585/output/index.ts
View file
@@ -1 +1 @@
import "./src/feat.ts";
import "./src/feat.js";
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4605/1/output/index.ts
View file
@@ -1 +1 @@
import "./src/rel.decorator.ts";
import "./src/rel.decorator.js";
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4605/2/output/index.ts
View file
@@ -1 +1 @@
import "./src/rel.decorator.ts";
import "./src/rel.decorator";
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4619/1/output/index.ts
View file
@@ -1 +1 @@
import "./src/rel.decorator.ts";
import "./src/rel.decorator.js";
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_module/tests/paths/issue-4619/2/output/index.ts
View file
@@ -1 +1 @@
import "./src/rel.decorator.ts";
import "./src/rel.decorator";

1 comment on commit 072bd13

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 072bd13 Previous: ca20d94 Ratio
es/full/bugs-1 343594 ns/iter (± 32186) 356249 ns/iter (± 20407) 0.96
es/full/minify/libraries/antd 1850216271 ns/iter (± 21092518) 1967249276 ns/iter (± 33762456) 0.94
es/full/minify/libraries/d3 421398538 ns/iter (± 15840516) 441578998 ns/iter (± 12787212) 0.95
es/full/minify/libraries/echarts 1643710542 ns/iter (± 35233875) 1652005840 ns/iter (± 66816973) 0.99
es/full/minify/libraries/jquery 125999302 ns/iter (± 11772171) 111068792 ns/iter (± 2939161) 1.13
es/full/minify/libraries/lodash 144649144 ns/iter (± 9654283) 126814501 ns/iter (± 4359175) 1.14
es/full/minify/libraries/moment 62482010 ns/iter (± 2747536) 63398303 ns/iter (± 1607889) 0.99
es/full/minify/libraries/react 20179618 ns/iter (± 956791) 21626929 ns/iter (± 485647) 0.93
es/full/minify/libraries/terser 339925271 ns/iter (± 16835106) 349011734 ns/iter (± 8723158) 0.97
es/full/minify/libraries/three 551570111 ns/iter (± 15569460) 574172952 ns/iter (± 16393970) 0.96
es/full/minify/libraries/typescript 3416571859 ns/iter (± 178801335) 3504142555 ns/iter (± 79780212) 0.98
es/full/minify/libraries/victory 850330127 ns/iter (± 26003414) 859214656 ns/iter (± 17077181) 0.99
es/full/minify/libraries/vue 158961652 ns/iter (± 7147358) 161046298 ns/iter (± 18571293) 0.99
es/full/codegen/es3 35129 ns/iter (± 2524) 33727 ns/iter (± 1997) 1.04
es/full/codegen/es5 34913 ns/iter (± 4435) 33643 ns/iter (± 1049) 1.04
es/full/codegen/es2015 34697 ns/iter (± 1443) 33871 ns/iter (± 2679) 1.02
es/full/codegen/es2016 34496 ns/iter (± 1247) 33733 ns/iter (± 1040) 1.02
es/full/codegen/es2017 34699 ns/iter (± 2110) 33797 ns/iter (± 1415) 1.03
es/full/codegen/es2018 34733 ns/iter (± 1703) 33683 ns/iter (± 1273) 1.03
es/full/codegen/es2019 34912 ns/iter (± 2622) 33604 ns/iter (± 1101) 1.04
es/full/codegen/es2020 34958 ns/iter (± 4246) 33677 ns/iter (± 1295) 1.04
es/full/all/es3 196268968 ns/iter (± 14400859) 192760212 ns/iter (± 8549033) 1.02
es/full/all/es5 189624038 ns/iter (± 17101929) 181547060 ns/iter (± 7814260) 1.04
es/full/all/es2015 147226418 ns/iter (± 12806903) 144928381 ns/iter (± 5724679) 1.02
es/full/all/es2016 148034573 ns/iter (± 11793679) 144712013 ns/iter (± 4750282) 1.02
es/full/all/es2017 150245391 ns/iter (± 13282719) 143166350 ns/iter (± 5142770) 1.05
es/full/all/es2018 152738976 ns/iter (± 14703883) 144221626 ns/iter (± 6971256) 1.06
es/full/all/es2019 158289970 ns/iter (± 12220238) 142035801 ns/iter (± 9576906) 1.11
es/full/all/es2020 140494470 ns/iter (± 12421699) 137723243 ns/iter (± 8606557) 1.02
es/full/parser 743271 ns/iter (± 48681) 708888 ns/iter (± 34921) 1.05
es/full/base/fixer 26765 ns/iter (± 2688) 26381 ns/iter (± 2148) 1.01
es/full/base/resolver_and_hygiene 94809 ns/iter (± 10527) 91731 ns/iter (± 5834) 1.03
serialization of ast node 230 ns/iter (± 6) 227 ns/iter (± 8) 1.01
serialization of serde 232 ns/iter (± 5) 229 ns/iter (± 14) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.