Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Preserve parentheses for new expr in optional chaining #6484

Merged
merged 3 commits into from Nov 21, 2022

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review November 20, 2022 11:11
@kdy1 kdy1 added this to the Planned milestone Nov 20, 2022
@kdy1 kdy1 self-assigned this Nov 20, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 enabled auto-merge (squash) November 20, 2022 13:34
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1ca281a into swc-project:main Nov 21, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.20 Nov 26, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 27, 2022
@magic-akari magic-akari deleted the fix/issue-6438 branch March 10, 2023 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can not remove constructor parentheses when using optional chaining after constructor.
4 participants