Skip to content

Commit

Permalink
chore(bindings): Fix jemalloc on aarch64 (#6541)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #5967.
  • Loading branch information
@kdy1
kdy1 committed Nov 29, 2022
1 parent 4c6e516 commit d56b5a8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/publish-node.yml
View file
Expand Up @@ -88,6 +88,7 @@ jobs:
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
build: >-
set -e &&
export JEMALLOC_SYS_WITH_LG_PAGE=16 &&
rustup target add aarch64-unknown-linux-gnu &&
RUSTFLAGS='' cargo build --manifest-path ./bindings/swc_cli/Cargo.toml --release --features plugin --target aarch64-unknown-linux-gnu &&
cp ./bindings/target/aarch64-unknown-linux-gnu/release/swc . && chmod +x ./swc &&
Expand All @@ -111,6 +112,7 @@ jobs:
downloadTarget: aarch64-unknown-linux-musl
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
build: >-
export JEMALLOC_SYS_WITH_LG_PAGE=16 &&
rustup toolchain install $(cat ./rust-toolchain) &&
rustup target add aarch64-unknown-linux-musl &&
RUSTFLAGS='-C target-feature=+crt-static -C link-arg=-lgcc' cargo build --manifest-path ./bindings/swc_cli/Cargo.toml --release --features plugin --target aarch64-unknown-linux-musl &&
Expand Down Expand Up @@ -471,4 +473,4 @@ jobs:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
run: |
./scripts/cli_upload_gh_release.sh
./scripts/cli_upload_gh_release.sh

1 comment on commit d56b5a8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d56b5a8 Previous: 7ee86d1 Ratio
es/full/bugs-1 387004 ns/iter (± 108570) 361465 ns/iter (± 33814) 1.07
es/full/minify/libraries/antd 2248408169 ns/iter (± 135247636) 2149423349 ns/iter (± 45299058) 1.05
es/full/minify/libraries/d3 509189747 ns/iter (± 28130505) 498117172 ns/iter (± 24397413) 1.02
es/full/minify/libraries/echarts 1890488867 ns/iter (± 106362970) 1796066119 ns/iter (± 51149483) 1.05
es/full/minify/libraries/jquery 118080067 ns/iter (± 15425773) 129733096 ns/iter (± 5100373) 0.91
es/full/minify/libraries/lodash 134573109 ns/iter (± 6429808) 146863513 ns/iter (± 11091787) 0.92
es/full/minify/libraries/moment 69941720 ns/iter (± 3431255) 74418430 ns/iter (± 21907297) 0.94
es/full/minify/libraries/react 23372146 ns/iter (± 1249174) 24013930 ns/iter (± 1553432) 0.97
es/full/minify/libraries/terser 436816849 ns/iter (± 12440388) 371160424 ns/iter (± 18303678) 1.18
es/full/minify/libraries/three 703558792 ns/iter (± 20283131) 648992026 ns/iter (± 16214238) 1.08
es/full/minify/libraries/typescript 3922000354 ns/iter (± 65661003) 3935763683 ns/iter (± 71035879) 1.00
es/full/minify/libraries/victory 923071808 ns/iter (± 19294566) 944277719 ns/iter (± 58591414) 0.98
es/full/minify/libraries/vue 167281726 ns/iter (± 6323912) 185564529 ns/iter (± 4780781) 0.90
es/full/codegen/es3 33835 ns/iter (± 1569) 34769 ns/iter (± 1215) 0.97
es/full/codegen/es5 33886 ns/iter (± 1878) 34176 ns/iter (± 1683) 0.99
es/full/codegen/es2015 33846 ns/iter (± 2617) 34166 ns/iter (± 938) 0.99
es/full/codegen/es2016 34146 ns/iter (± 2866) 34222 ns/iter (± 449) 1.00
es/full/codegen/es2017 33864 ns/iter (± 2650) 34165 ns/iter (± 780) 0.99
es/full/codegen/es2018 33761 ns/iter (± 1950) 34075 ns/iter (± 1342) 0.99
es/full/codegen/es2019 33745 ns/iter (± 1957) 34041 ns/iter (± 1161) 0.99
es/full/codegen/es2020 33983 ns/iter (± 1735) 33972 ns/iter (± 2363) 1.00
es/full/all/es3 194612332 ns/iter (± 13849017) 199488698 ns/iter (± 13281952) 0.98
es/full/all/es5 182510577 ns/iter (± 11049288) 187736669 ns/iter (± 12146066) 0.97
es/full/all/es2015 146360917 ns/iter (± 5711217) 150262664 ns/iter (± 9629165) 0.97
es/full/all/es2016 149358286 ns/iter (± 8303475) 148044642 ns/iter (± 9887801) 1.01
es/full/all/es2017 153756551 ns/iter (± 14321092) 147161271 ns/iter (± 10710502) 1.04
es/full/all/es2018 150009124 ns/iter (± 7501386) 145129666 ns/iter (± 13071911) 1.03
es/full/all/es2019 155178843 ns/iter (± 13315001) 141851388 ns/iter (± 7287760) 1.09
es/full/all/es2020 145421278 ns/iter (± 8831633) 136151261 ns/iter (± 9260008) 1.07
es/full/parser 774057 ns/iter (± 63031) 717576 ns/iter (± 37872) 1.08
es/full/base/fixer 28442 ns/iter (± 2715) 26267 ns/iter (± 1771) 1.08
es/full/base/resolver_and_hygiene 95403 ns/iter (± 4686) 91878 ns/iter (± 7557) 1.04
serialization of ast node 231 ns/iter (± 28) 216 ns/iter (± 8) 1.07
serialization of serde 258 ns/iter (± 33) 220 ns/iter (± 6) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.