feat(es/minifier): Mark ref to fn as non-call in alias analyzer (#6088)

crates/swc/tests/vercel/full/d3-time-format/1/output/index.js

@@ -378,7 +378,7 @@ function nu(n, t) {
     return D(n.getFullYear() % 100, t, 2);
 }
 function nc(n, t) {
-    return n = nn(n), D(n.getFullYear() % 100, t, 2);
+    return D((n = nn(n)).getFullYear() % 100, t, 2);
 }
 function ni(n, t) {
     return D(n.getFullYear() % 10000, t, 4);
@@ -442,7 +442,7 @@ function nM(n, t) {
     return D(n.getUTCFullYear() % 100, t, 2);
 }
 function np(n, t) {
-    return n = nx(n), D(n.getUTCFullYear() % 100, t, 2);
+    return D((n = nx(n)).getUTCFullYear() % 100, t, 2);
 }
 function nH(n, t) {
     return D(n.getUTCFullYear() % 10000, t, 4);

crates/swc/tests/vercel/full/react-autosuggest/1/output/index.js

@@ -119,9 +119,9 @@ var ItemsList = function(_Component) {
             if (!_instanceof(instance, Constructor)) throw TypeError("Cannot call a class as a function");
         }(this, ItemsList);
         for(var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++)args[_key] = arguments[_key];
-        return _this = _super.call.apply(_super, [
+        return _defineProperty(_assertThisInitialized(_this = _super.call.apply(_super, [
             this
-        ].concat(args)), _defineProperty(_assertThisInitialized(_this), "storeHighlightedItemReference", function(highlightedItem) {
+        ].concat(args))), "storeHighlightedItemReference", function(highlightedItem) {
             _this.props.onHighlightedItemChange(null === highlightedItem ? null : highlightedItem.item);
         }), _this;
     }

crates/swc_ecma_minifier/src/analyzer/mod.rs

@@ -85,6 +85,7 @@ pub(crate) struct VarUsageInfo {
     /// `true` if the enclosing function defines this variable as a parameter.
     pub declared_as_fn_param: bool,
 
+    pub declared_as_fn_decl: bool,
     pub declared_as_fn_expr: bool,
 
     pub assign_count: u32,
@@ -224,19 +225,22 @@ impl ProgramData {
                         let infects = &info.infects;
                         if !infects.is_empty() {
                             let old_len = ids.len();
-                            match iid.1 {
-                                AccessKind::Reference => {
-                                    // This is not a call, so effects from call can be skipped
-                                    ids.extend(
-                                        infects
-                                            .iter()
-                                            .filter(|(_, kind)| *kind != AccessKind::Call)
-                                            .cloned(),
-                                    );
-                                }
-                                AccessKind::Call => {
-                                    ids.extend_from_slice(infects.as_slice());
-                                }
+
+                            // This is not a call, so effects from call can be skipped
+                            let can_skip_non_call = matches!(iid.1, AccessKind::Reference)
+                                || (info.declared_count == 1
+                                    && info.declared_as_fn_decl
+                                    && !info.reassigned());
+
+                            if can_skip_non_call {
+                                ids.extend(
+                                    infects
+                                        .iter()
+                                        .filter(|(_, kind)| *kind != AccessKind::Call)
+                                        .cloned(),
+                                );
+                            } else {
+                                ids.extend_from_slice(infects.as_slice());
                             }
                             let new_len = ids.len();
                             ranges.push(old_len..new_len);
@@ -390,11 +394,17 @@ where
         i: &Ident,
         has_init: bool,
         kind: Option<VarDeclKind>,
-        _is_fn_decl: bool,
+        is_fn_decl: bool,
     ) -> &mut S::VarData {
         self.scope.add_declared_symbol(i);
 
-        self.data.declare_decl(self.ctx, i, has_init, kind)
+        let v = self.data.declare_decl(self.ctx, i, has_init, kind);
+
+        if is_fn_decl {
+            v.mark_declared_as_fn_decl();
+        }
+
+        v
     }
 
     fn visit_in_cond<T: VisitWith<Self>>(&mut self, t: &T) {

crates/swc_ecma_minifier/src/analyzer/storage/mod.rs

@@ -49,6 +49,8 @@ pub(crate) trait VarDataLike: Sized {
     /// See `declared_as_fn_param` of [crate::analyzer::VarUsageInfo].
     fn mark_declared_as_fn_param(&mut self);
 
+    fn mark_declared_as_fn_decl(&mut self);
+
     fn mark_declared_as_fn_expr(&mut self);
 
     fn mark_has_property_access(&mut self);

crates/swc_ecma_minifier/src/analyzer/storage/normal.rs

@@ -62,6 +62,7 @@ impl Storage for ProgramData {
                     e.get_mut().declared |= var_info.declared;
                     e.get_mut().declared_count += var_info.declared_count;
                     e.get_mut().declared_as_fn_param |= var_info.declared_as_fn_param;
+                    e.get_mut().declared_as_fn_decl |= var_info.declared_as_fn_decl;
                     e.get_mut().declared_as_fn_expr |= var_info.declared_as_fn_expr;
 
                     // If a var is registered at a parent scope, it means that it's delcared before
@@ -295,6 +296,10 @@ impl VarDataLike for VarUsageInfo {
         self.declared_as_fn_param = true;
     }
 
+    fn mark_declared_as_fn_decl(&mut self) {
+        self.declared_as_fn_decl = true;
+    }
+
     fn mark_declared_as_fn_expr(&mut self) {
         self.declared_as_fn_expr = true;
     }

crates/swc_ecma_minifier/tests/benches-full/echarts.js

@@ -13138,12 +13138,12 @@
         }, ECharts.prototype.convertFromPixel = function(finder, value) {
             return doConvertPixel(this, 'convertFromPixel', finder, value);
         }, ECharts.prototype.containPixel = function(finder, value) {
+            var result;
             if (this._disposed) {
                 disposedWarning(this.id);
                 return;
             }
-            var result, findResult = parseFinder(this._model, finder);
-            return each(findResult, function(models, key) {
+            return each(parseFinder(this._model, finder), function(models, key) {
                 key.indexOf('Models') >= 0 && each(models, function(model) {
                     var coordSys = model.coordinateSystem;
                     if (coordSys && coordSys.containPoint) result = result || !!coordSys.containPoint(value);
@@ -31185,7 +31185,7 @@
             if (!1 === clipPathOpt) el && el.getClipPath() && el.removeClipPath();
             else if (clipPathOpt) {
                 var clipPath = el.getClipPath();
-                clipPath && doesElNeedRecreate(clipPath, clipPathOpt) && (clipPath = null), !clipPath && (clipPath = createEl(clipPathOpt), assert(clipPath instanceof Path, 'Only any type of `path` can be used in `clipPath`, rather than ' + clipPath.type + '.'), el.setClipPath(clipPath)), updateElNormal(null, clipPath, null, dataIndex, clipPathOpt, null, null, seriesModel, isInit, !1);
+                clipPath && doesElNeedRecreate(clipPath, clipPathOpt) && (clipPath = null), !clipPath && (assert((clipPath = createEl(clipPathOpt)) instanceof Path, 'Only any type of `path` can be used in `clipPath`, rather than ' + clipPath.type + '.'), el.setClipPath(clipPath)), updateElNormal(null, clipPath, null, dataIndex, clipPathOpt, null, null, seriesModel, isInit, !1);
             }
         }(el, dataIndex, elOption, seriesModel, isInit);
         var pendingAllPropsFinal = updateElNormal(api, el, thisElIsMorphTo, dataIndex, elOption, elOption.style, attachedTxInfoTmp, seriesModel, isInit, !1);

crates/swc_ecma_minifier/tests/benches-full/lodash.js

@@ -2421,7 +2421,7 @@
             });
         }, lodash.conforms = function(source) {
             var source1, props;
-            return source1 = baseClone(source, 1), props = keys(source1), function(object) {
+            return props = keys(source1 = baseClone(source, 1)), function(object) {
                 return baseConformsTo(object, source1, props);
             };
         }, lodash.constant = constant, lodash.countBy = countBy, lodash.create = function(prototype, properties) {

crates/swc_ecma_minifier/tests/benches-full/moment.js

@@ -951,8 +951,8 @@
     }
     function createAdder(direction, name) {
         return function(val, period) {
-            var dur, tmp;
-            return null === period || isNaN(+period) || (deprecateSimple(name, 'moment().' + name + '(period, number) is deprecated. Please use moment().' + name + "(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info."), tmp = val, val = period, period = tmp), dur = createDuration(val, period), addSubtract(this, dur, direction), this;
+            var tmp;
+            return null === period || isNaN(+period) || (deprecateSimple(name, 'moment().' + name + '(period, number) is deprecated. Please use moment().' + name + "(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info."), tmp = val, val = period, period = tmp), addSubtract(this, createDuration(val, period), direction), this;
         };
     }
     function addSubtract(mom, duration, isAdding, updateOffset) {
@@ -1771,7 +1771,7 @@
     }, proto$2.months = months, proto$2.years = years, proto$2.humanize = function(argWithSuffix, argThresholds) {
         if (!this.isValid()) return this.localeData().invalidDate();
         var posNegDuration, withoutSuffix, thresholds1, locale, duration, seconds, minutes, hours, days, months, weeks, years, a, locale1, output, withSuffix = !1, th = thresholds;
-        return 'object' == typeof argWithSuffix && (argThresholds = argWithSuffix, argWithSuffix = !1), 'boolean' == typeof argWithSuffix && (withSuffix = argWithSuffix), 'object' == typeof argThresholds && (th = Object.assign({}, thresholds, argThresholds), null != argThresholds.s && null == argThresholds.ss && (th.ss = argThresholds.s - 1)), locale1 = this.localeData(), withoutSuffix = !withSuffix, thresholds1 = th, duration = createDuration(this).abs(), seconds = round(duration.as('s')), minutes = round(duration.as('m')), hours = round(duration.as('h')), days = round(duration.as('d')), months = round(duration.as('M')), weeks = round(duration.as('w')), years = round(duration.as('y')), a = seconds <= thresholds1.ss && [
+        return 'object' == typeof argWithSuffix && (argThresholds = argWithSuffix, argWithSuffix = !1), 'boolean' == typeof argWithSuffix && (withSuffix = argWithSuffix), 'object' == typeof argThresholds && (th = Object.assign({}, thresholds, argThresholds), null != argThresholds.s && null == argThresholds.ss && (th.ss = argThresholds.s - 1)), locale1 = this.localeData(), withoutSuffix = !withSuffix, thresholds1 = th, seconds = round((duration = createDuration(this).abs()).as('s')), minutes = round(duration.as('m')), hours = round(duration.as('h')), days = round(duration.as('d')), months = round(duration.as('M')), weeks = round(duration.as('w')), years = round(duration.as('y')), a = seconds <= thresholds1.ss && [
             's',
             seconds
         ] || seconds < thresholds1.s && [

crates/swc_ecma_minifier/tests/benches-full/react.js

@@ -566,11 +566,7 @@
                         !error$1 || error$1 instanceof Error || (setCurrentlyValidatingElement(element), error("%s: type specification of %s `%s` is invalid; the type checker function must return `null` or an `Error` but returned a %s. You may have forgotten to pass an argument to the type checker creator (arrayOf, instanceOf, objectOf, oneOf, oneOfType, and shape all require an argument).", componentName || 'React class', location, typeSpecName, typeof error$1), setCurrentlyValidatingElement(null)), error$1 instanceof Error && !(error$1.message in loggedTypeFailures) && (loggedTypeFailures[error$1.message] = !0, setCurrentlyValidatingElement(element), error('Failed %s type: %s', location, error$1.message), setCurrentlyValidatingElement(null));
                     }
                 }(propTypes, element.props, 'prop', name, element);
-            } else if (void 0 !== type.PropTypes && !propTypesMisspellWarningShown) {
-                propTypesMisspellWarningShown = !0;
-                var _name = getComponentName(type);
-                error('Component %s declared `PropTypes` instead of `propTypes`. Did you misspell the property assignment?', _name || 'Unknown');
-            }
+            } else void 0 === type.PropTypes || propTypesMisspellWarningShown || (propTypesMisspellWarningShown = !0, error('Component %s declared `PropTypes` instead of `propTypes`. Did you misspell the property assignment?', getComponentName(type) || 'Unknown'));
             'function' != typeof type.getDefaultProps || type.getDefaultProps.isReactClassApproved || error("getDefaultProps is only used on classic React.createClass definitions. Use a static property named `defaultProps` instead.");
         }
     }