Skip to content

Commit

Permalink
fix(bindings): Fix type definitions (#6018)
Browse files Browse the repository at this point in the history
  • Loading branch information
RiESAEX committed Oct 2, 2022
1 parent 185d6fe commit 8fea8ca
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions node-swc/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@ export interface TerserCompressOptions {
export interface TerserMangleOptions {
props?: TerserManglePropertiesOptions,

top_level?: boolean,
toplevel?: boolean,

keep_class_names?: boolean,
keep_classnames?: boolean,

keep_fn_names?: boolean,
keep_fnames?: boolean,

keep_private_props?: boolean,

Expand Down Expand Up @@ -893,7 +893,7 @@ export interface GlobalPassOption {
envs?: string[];
}

export type ModuleConfig = Es6Config | CommonJsConfig | UmdConfig | AmdConfig | NodeNextConfig;
export type ModuleConfig = Es6Config | CommonJsConfig | UmdConfig | AmdConfig | NodeNextConfig | SystemjsConfig;

export interface BaseModuleConfig {
/**
Expand Down Expand Up @@ -1054,6 +1054,8 @@ export interface BaseModuleConfig {
* If set to true, dynamic imports will be preserved.
*/
ignoreDynamic?: boolean;
allowTopLevelThis?: boolean;
preserveImportMeta?: boolean;
}

export interface Es6Config extends BaseModuleConfig {
Expand All @@ -1077,7 +1079,10 @@ export interface AmdConfig extends BaseModuleConfig {
type: "amd";
moduleId?: string;
}

export interface SystemjsConfig {
type: "systemjs";
allowTopLevelThis?: boolean;
}
export interface Output {
/**
* Transformed code
Expand Down

1 comment on commit 8fea8ca

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8fea8ca Previous: 1aae503 Ratio
es/full/minify/libraries/antd 1841391523 ns/iter (± 20323362) 1837760482 ns/iter (± 16087219) 1.00
es/full/minify/libraries/d3 331738784 ns/iter (± 5701503) 346577788 ns/iter (± 6906374) 0.96
es/full/minify/libraries/echarts 1403451183 ns/iter (± 14666705) 1398168888 ns/iter (± 12295295) 1.00
es/full/minify/libraries/jquery 84710602 ns/iter (± 8493989) 84180740 ns/iter (± 2045305) 1.01
es/full/minify/libraries/lodash 107514843 ns/iter (± 1840609) 108532729 ns/iter (± 3540211) 0.99
es/full/minify/libraries/moment 48998620 ns/iter (± 1020148) 48835311 ns/iter (± 572181) 1.00
es/full/minify/libraries/react 18110641 ns/iter (± 301666) 18175738 ns/iter (± 128680) 1.00
es/full/minify/libraries/terser 252484325 ns/iter (± 7419089) 262146806 ns/iter (± 13096626) 0.96
es/full/minify/libraries/three 472471359 ns/iter (± 6629799) 472483817 ns/iter (± 9898782) 1.00
es/full/minify/libraries/typescript 3162329329 ns/iter (± 33055537) 3081810685 ns/iter (± 31959732) 1.03
es/full/minify/libraries/victory 718258607 ns/iter (± 11636994) 721386265 ns/iter (± 18025321) 1.00
es/full/minify/libraries/vue 121552478 ns/iter (± 2769453) 124597702 ns/iter (± 4790823) 0.98
es/full/codegen/es3 32561 ns/iter (± 629) 33553 ns/iter (± 350) 0.97
es/full/codegen/es5 32643 ns/iter (± 1114) 33569 ns/iter (± 311) 0.97
es/full/codegen/es2015 32454 ns/iter (± 854) 33560 ns/iter (± 2422) 0.97
es/full/codegen/es2016 32463 ns/iter (± 1760) 33569 ns/iter (± 624) 0.97
es/full/codegen/es2017 32386 ns/iter (± 440) 33659 ns/iter (± 999) 0.96
es/full/codegen/es2018 32407 ns/iter (± 559) 33553 ns/iter (± 459) 0.97
es/full/codegen/es2019 32479 ns/iter (± 658) 33536 ns/iter (± 506) 0.97
es/full/codegen/es2020 32441 ns/iter (± 898) 33563 ns/iter (± 1459) 0.97
es/full/all/es3 184186766 ns/iter (± 5721972) 188730688 ns/iter (± 4889501) 0.98
es/full/all/es5 175155238 ns/iter (± 3699940) 179142687 ns/iter (± 4894894) 0.98
es/full/all/es2015 140864725 ns/iter (± 3043893) 144210754 ns/iter (± 5619238) 0.98
es/full/all/es2016 139814525 ns/iter (± 3257790) 142902375 ns/iter (± 5799345) 0.98
es/full/all/es2017 139234700 ns/iter (± 2821003) 140987069 ns/iter (± 3472165) 0.99
es/full/all/es2018 138030158 ns/iter (± 3896289) 141870079 ns/iter (± 6061644) 0.97
es/full/all/es2019 137155754 ns/iter (± 2312788) 146665310 ns/iter (± 12509212) 0.94
es/full/all/es2020 132307924 ns/iter (± 2063388) 136580280 ns/iter (± 5314427) 0.97
es/full/parser 689868 ns/iter (± 20805) 719586 ns/iter (± 31691) 0.96
es/full/base/fixer 25046 ns/iter (± 1585) 26793 ns/iter (± 479) 0.93
es/full/base/resolver_and_hygiene 91099 ns/iter (± 2090) 93897 ns/iter (± 1875) 0.97
serialization of ast node 207 ns/iter (± 7) 214 ns/iter (± 11) 0.97
serialization of serde 211 ns/iter (± 4) 220 ns/iter (± 6) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.