Skip to content

Commit

Permalink
fix(es/preset-env): Align polyfills with `@babel/plugin-polyfill-core…
Browse files Browse the repository at this point in the history
…js3` (#6673)
  • Loading branch information
JSerFeng committed Dec 19, 2022
1 parent 2858805 commit 5fed222
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions crates/swc_ecma_preset_env/src/lib.rs
Expand Up @@ -388,10 +388,13 @@ impl Fold for Polyfills {
},
};
let required = required
.into_iter()
.filter(|s| !self.excludes.contains(&**s))
.iter()
.filter(|s| {
!s.starts_with("esnext") || !required.contains(&s.replace("esnext", "es").as_str())
})
.filter(|s| !self.excludes.contains(&***s))
.map(|s| -> JsWord {
if s != "regenerator-runtime/runtime.js" {
if *s != "regenerator-runtime/runtime.js" {
format!("core-js/modules/{}.js", s).into()
} else {
"regenerator-runtime/runtime.js".to_string().into()
Expand Down

1 comment on commit 5fed222

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5fed222 Previous: 46241b4 Ratio
es/full/bugs-1 301781 ns/iter (± 2946) 295676 ns/iter (± 3851) 1.02
es/full/minify/libraries/antd 1651208042 ns/iter (± 24910274) 1784114373 ns/iter (± 45201857) 0.93
es/full/minify/libraries/d3 308173386 ns/iter (± 5960960) 318262101 ns/iter (± 6502527) 0.97
es/full/minify/libraries/echarts 1272917467 ns/iter (± 8278490) 1355588338 ns/iter (± 8397199) 0.94
es/full/minify/libraries/jquery 91359518 ns/iter (± 830160) 91279827 ns/iter (± 1197574) 1.00
es/full/minify/libraries/lodash 108115545 ns/iter (± 838906) 108030652 ns/iter (± 1756249) 1.00
es/full/minify/libraries/moment 54353958 ns/iter (± 1608468) 53698178 ns/iter (± 521767) 1.01
es/full/minify/libraries/react 19369543 ns/iter (± 299866) 19271067 ns/iter (± 119097) 1.01
es/full/minify/libraries/terser 257586213 ns/iter (± 5186673) 257997122 ns/iter (± 4611003) 1.00
es/full/minify/libraries/three 470738195 ns/iter (± 4511335) 499386182 ns/iter (± 7773955) 0.94
es/full/minify/libraries/typescript 3106745372 ns/iter (± 8822647) 3318174763 ns/iter (± 18737083) 0.94
es/full/minify/libraries/victory 717653929 ns/iter (± 5615753) 731994413 ns/iter (± 15109984) 0.98
es/full/minify/libraries/vue 136170010 ns/iter (± 1673835) 133197106 ns/iter (± 1898776) 1.02
es/full/codegen/es3 27815 ns/iter (± 218) 27283 ns/iter (± 59) 1.02
es/full/codegen/es5 27830 ns/iter (± 47) 27220 ns/iter (± 57) 1.02
es/full/codegen/es2015 27834 ns/iter (± 37) 27203 ns/iter (± 46) 1.02
es/full/codegen/es2016 27820 ns/iter (± 33) 27217 ns/iter (± 70) 1.02
es/full/codegen/es2017 27752 ns/iter (± 53) 27231 ns/iter (± 84) 1.02
es/full/codegen/es2018 27820 ns/iter (± 58) 27260 ns/iter (± 69) 1.02
es/full/codegen/es2019 27775 ns/iter (± 52) 27237 ns/iter (± 37) 1.02
es/full/codegen/es2020 27814 ns/iter (± 25) 27243 ns/iter (± 46) 1.02
es/full/all/es3 170660258 ns/iter (± 2379578) 165159022 ns/iter (± 3392272) 1.03
es/full/all/es5 161802776 ns/iter (± 2026695) 156641599 ns/iter (± 2779625) 1.03
es/full/all/es2015 121079267 ns/iter (± 972513) 117698932 ns/iter (± 596741) 1.03
es/full/all/es2016 119966706 ns/iter (± 874193) 117114767 ns/iter (± 1370973) 1.02
es/full/all/es2017 119079015 ns/iter (± 1035819) 116148239 ns/iter (± 707306) 1.03
es/full/all/es2018 118081369 ns/iter (± 927912) 114205162 ns/iter (± 774532) 1.03
es/full/all/es2019 117395047 ns/iter (± 969610) 113123206 ns/iter (± 569387) 1.04
es/full/all/es2020 113098765 ns/iter (± 1102285) 109646523 ns/iter (± 984167) 1.03
es/full/parser 511554 ns/iter (± 8274) 504540 ns/iter (± 8433) 1.01
es/full/base/fixer 22053 ns/iter (± 26) 22161 ns/iter (± 32) 1.00
es/full/base/resolver_and_hygiene 78156 ns/iter (± 120) 78027 ns/iter (± 88) 1.00
serialization of ast node 119 ns/iter (± 0) 119 ns/iter (± 0) 1
serialization of serde 122 ns/iter (± 0) 122 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27551172 ns/iter (± 164328) 27616169 ns/iter (± 165798) 1.00
css/visitor/compare/clone 2092059 ns/iter (± 6033) 2046425 ns/iter (± 21643) 1.02
css/visitor/compare/visit_mut_span 2274993 ns/iter (± 8979) 2259974 ns/iter (± 6011) 1.01
css/visitor/compare/visit_mut_span_panic 2321251 ns/iter (± 5433) 2314048 ns/iter (± 9994) 1.00
css/visitor/compare/fold_span 3019018 ns/iter (± 18281) 3002014 ns/iter (± 24805) 1.01
css/visitor/compare/fold_span_panic 3157791 ns/iter (± 24548) 3143713 ns/iter (± 39238) 1.00
css/lexer/bootstrap_5_1_3 5220824 ns/iter (± 2209) 5211651 ns/iter (± 1567) 1.00
css/lexer/foundation_6_7_4 4433649 ns/iter (± 1903) 4424247 ns/iter (± 1550) 1.00
css/lexer/tailwind_3_1_1 830364 ns/iter (± 353) 829644 ns/iter (± 467) 1.00
css/parser/bootstrap_5_1_3 20914107 ns/iter (± 414256) 20796839 ns/iter (± 148558) 1.01
css/parser/foundation_6_7_4 16692901 ns/iter (± 69115) 16541096 ns/iter (± 39904) 1.01
css/parser/tailwind_3_1_1 3194358 ns/iter (± 3865) 3193381 ns/iter (± 4266) 1.00
es/codegen/colors 328315 ns/iter (± 184273) 329146 ns/iter (± 184339) 1.00
es/codegen/large 1179575 ns/iter (± 615325) 1179399 ns/iter (± 615900) 1.00
es/codegen/with-parser/colors 46669 ns/iter (± 305) 46324 ns/iter (± 667) 1.01
es/codegen/with-parser/large 515433 ns/iter (± 1420) 511178 ns/iter (± 1093) 1.01
es/minify/libraries/antd 1444590240 ns/iter (± 13835848) 1534343139 ns/iter (± 20458910) 0.94
es/minify/libraries/d3 264293807 ns/iter (± 3662536) 262908336 ns/iter (± 3133349) 1.01
es/minify/libraries/echarts 1099133568 ns/iter (± 5662166) 1147002871 ns/iter (± 10040408) 0.96
es/minify/libraries/jquery 78555244 ns/iter (± 658815) 79184065 ns/iter (± 996331) 0.99
es/minify/libraries/lodash 95446057 ns/iter (± 804762) 95546577 ns/iter (± 654871) 1.00
es/minify/libraries/moment 46274920 ns/iter (± 403100) 46417653 ns/iter (± 440103) 1.00
es/minify/libraries/react 17180685 ns/iter (± 121585) 16950593 ns/iter (± 127417) 1.01
es/minify/libraries/terser 218596775 ns/iter (± 2770219) 220936176 ns/iter (± 2276917) 0.99
es/minify/libraries/three 379130752 ns/iter (± 3990504) 379738387 ns/iter (± 11401814) 1.00
es/minify/libraries/typescript 2630954662 ns/iter (± 14040766) 2749691497 ns/iter (± 17344437) 0.96
es/minify/libraries/victory 602040306 ns/iter (± 8491445) 593004004 ns/iter (± 21502270) 1.02
es/minify/libraries/vue 118569255 ns/iter (± 998676) 116272483 ns/iter (± 1018702) 1.02
es/visitor/compare/clone 2392077 ns/iter (± 8311) 2405047 ns/iter (± 23023) 0.99
es/visitor/compare/visit_mut_span 2816040 ns/iter (± 23006) 2814761 ns/iter (± 15445) 1.00
es/visitor/compare/visit_mut_span_panic 2854179 ns/iter (± 13650) 2855552 ns/iter (± 12364) 1.00
es/visitor/compare/fold_span 3949367 ns/iter (± 44381) 3940892 ns/iter (± 10514) 1.00
es/visitor/compare/fold_span_panic 4103248 ns/iter (± 10545) 4096255 ns/iter (± 35677) 1.00
es/lexer/colors 17249 ns/iter (± 28) 17343 ns/iter (± 7) 0.99
es/lexer/angular 8245389 ns/iter (± 2858) 8269456 ns/iter (± 7011) 1.00
es/lexer/backbone 1074610 ns/iter (± 370) 1077989 ns/iter (± 509) 1.00
es/lexer/jquery 5968456 ns/iter (± 3755) 5985337 ns/iter (± 3428) 1.00
es/lexer/jquery mobile 9196474 ns/iter (± 5999) 9217522 ns/iter (± 4421) 1.00
es/lexer/mootools 4682101 ns/iter (± 5017) 4703137 ns/iter (± 3525) 1.00
es/lexer/underscore 899090 ns/iter (± 769) 901216 ns/iter (± 747) 1.00
es/lexer/three 27999071 ns/iter (± 40894) 28058129 ns/iter (± 21098) 1.00
es/lexer/yui 5049403 ns/iter (± 2208) 5065706 ns/iter (± 2619) 1.00
es/parser/colors 30932 ns/iter (± 69) 30597 ns/iter (± 143) 1.01
es/parser/angular 15773706 ns/iter (± 224447) 15601920 ns/iter (± 110237) 1.01
es/parser/backbone 2325235 ns/iter (± 12019) 2322252 ns/iter (± 11640) 1.00
es/parser/jquery 12755896 ns/iter (± 185379) 12597070 ns/iter (± 52120) 1.01
es/parser/jquery mobile 20952807 ns/iter (± 348747) 19887307 ns/iter (± 195072) 1.05
es/parser/mootools 9680035 ns/iter (± 28759) 9632073 ns/iter (± 60782) 1.00
es/parser/underscore 1978687 ns/iter (± 10924) 1977314 ns/iter (± 10785) 1.00
es/parser/three 59900371 ns/iter (± 169406) 59881501 ns/iter (± 704040) 1.00
es/parser/yui 9628294 ns/iter (± 47010) 9581110 ns/iter (± 50449) 1.00
es/preset-env/usage/builtin_type 143080 ns/iter (± 33298) 141484 ns/iter (± 31989) 1.01
es/preset-env/usage/property 21186 ns/iter (± 90) 20640 ns/iter (± 77) 1.03
es/resolver/typescript 111553650 ns/iter (± 2050342) 120490691 ns/iter (± 1696767) 0.93
es/fixer/typescript 84370905 ns/iter (± 404534) 94409430 ns/iter (± 1422698) 0.89
es/hygiene/typescript 167748427 ns/iter (± 1100210) 185762541 ns/iter (± 1245613) 0.90
es/resolver_with_hygiene/typescript 298310607 ns/iter (± 2008429) 316665214 ns/iter (± 1482629) 0.94
es/visitor/base-perf/module_clone 76723 ns/iter (± 1597) 76817 ns/iter (± 1150) 1.00
es/visitor/base-perf/fold_empty 87133 ns/iter (± 1354) 86972 ns/iter (± 1607) 1.00
es/visitor/base-perf/fold_noop_impl_all 86929 ns/iter (± 1671) 86787 ns/iter (± 1550) 1.00
es/visitor/base-perf/fold_noop_impl_vec 87011 ns/iter (± 1507) 87137 ns/iter (± 1937) 1.00
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 61 ns/iter (± 0) 0.97
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 107 ns/iter (± 0) 0.96
es/visitor/base-perf/boxing_unboxed 102 ns/iter (± 0) 103 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_contains_this 3653 ns/iter (± 91) 3422 ns/iter (± 66) 1.07
es/base/parallel/resolver/typescript 4932369215 ns/iter (± 519066938) 5865513944 ns/iter (± 579190653) 0.84
es/base/parallel/hygiene/typescript 2006592821 ns/iter (± 23896821) 2219728850 ns/iter (± 32686570) 0.90
misc/visitors/time-complexity/time 5 104 ns/iter (± 0) 104 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 321 ns/iter (± 4) 320 ns/iter (± 0) 1.00
misc/visitors/time-complexity/time 15 657 ns/iter (± 0) 657 ns/iter (± 0) 1
misc/visitors/time-complexity/time 20 1231 ns/iter (± 0) 1230 ns/iter (± 1) 1.00
misc/visitors/time-complexity/time 40 6615 ns/iter (± 1) 6772 ns/iter (± 84) 0.98
misc/visitors/time-complexity/time 60 17252 ns/iter (± 37) 17293 ns/iter (± 29) 1.00
es/full-target/es2016 187376 ns/iter (± 605) 188613 ns/iter (± 685) 0.99
es/full-target/es2017 182118 ns/iter (± 688) 183135 ns/iter (± 586) 0.99
es/full-target/es2018 170859 ns/iter (± 395) 172449 ns/iter (± 469) 0.99
es2020_nullish_coalescing 67044 ns/iter (± 121) 67636 ns/iter (± 155) 0.99
es2020_optional_chaining 95542 ns/iter (± 7660) 95893 ns/iter (± 231) 1.00
es2022_class_properties 94066 ns/iter (± 98) 93392 ns/iter (± 91) 1.01
es2018_object_rest_spread 71531 ns/iter (± 123) 71445 ns/iter (± 127) 1.00
es2019_optional_catch_binding 61479 ns/iter (± 100) 61612 ns/iter (± 127) 1.00
es2017_async_to_generator 61877 ns/iter (± 105) 62036 ns/iter (± 75) 1.00
es2016_exponentiation 65246 ns/iter (± 70) 64943 ns/iter (± 117) 1.00
es2015_arrow 70083 ns/iter (± 179) 69912 ns/iter (± 203) 1.00
es2015_block_scoped_fn 66048 ns/iter (± 141) 65992 ns/iter (± 102) 1.00
es2015_block_scoping 146680 ns/iter (± 10724) 146369 ns/iter (± 8600) 1.00
es2015_classes 117216 ns/iter (± 534) 117646 ns/iter (± 496) 1.00
es2015_computed_props 61759 ns/iter (± 77) 61790 ns/iter (± 57) 1.00
es2015_destructuring 116272 ns/iter (± 225) 116193 ns/iter (± 408) 1.00
es2015_duplicate_keys 64661 ns/iter (± 139) 64029 ns/iter (± 280) 1.01
es2015_parameters 79947 ns/iter (± 185) 79378 ns/iter (± 100) 1.01
es2015_fn_name 67181 ns/iter (± 428) 66866 ns/iter (± 546) 1.00
es2015_for_of 64535 ns/iter (± 80) 64432 ns/iter (± 157) 1.00
es2015_instanceof 63774 ns/iter (± 106) 63429 ns/iter (± 91) 1.01
es2015_shorthand_property 61259 ns/iter (± 100) 61231 ns/iter (± 82) 1.00
es2015_spread 61365 ns/iter (± 89) 61396 ns/iter (± 74) 1.00
es2015_sticky_regex 62434 ns/iter (± 86) 62164 ns/iter (± 84) 1.00
es2015_typeof_symbol 62761 ns/iter (± 151) 62884 ns/iter (± 117) 1.00
es/transform/baseline/base 52182 ns/iter (± 95) 52064 ns/iter (± 113) 1.00
es/transform/baseline/common_reserved_word 63013 ns/iter (± 97) 62780 ns/iter (± 132) 1.00
es/transform/baseline/common_typescript 169892 ns/iter (± 7854) 146778 ns/iter (± 7997) 1.16
es/target/es3 170178 ns/iter (± 312) 170321 ns/iter (± 314) 1.00
es/target/es2015 629703 ns/iter (± 1139) 630394 ns/iter (± 1159) 1.00
es/target/es2016 65405 ns/iter (± 85) 65007 ns/iter (± 119) 1.01
es/target/es2017 62022 ns/iter (± 75) 62096 ns/iter (± 108) 1.00
es/target/es2018 81669 ns/iter (± 98) 81351 ns/iter (± 124) 1.00
es/target/es2020 132589 ns/iter (± 148) 132683 ns/iter (± 256) 1.00
babelify-only 671490 ns/iter (± 4862) 672327 ns/iter (± 770) 1.00
parse_and_babelify_angular 45151239 ns/iter (± 832078) 42487031 ns/iter (± 494769) 1.06
parse_and_babelify_backbone 5543415 ns/iter (± 47923) 5377667 ns/iter (± 92751) 1.03
parse_and_babelify_jquery 33240651 ns/iter (± 577571) 32528380 ns/iter (± 622778) 1.02
parse_and_babelify_jquery_mobile 57035174 ns/iter (± 639152) 56072374 ns/iter (± 732489) 1.02
parse_and_babelify_mootools 33294983 ns/iter (± 330112) 34394499 ns/iter (± 407458) 0.97
parse_and_babelify_underscore 4373188 ns/iter (± 21781) 4326567 ns/iter (± 29384) 1.01
parse_and_babelify_yui 33067053 ns/iter (± 199356) 33691936 ns/iter (± 550646) 0.98
html/minify/document/css_spec 42072804 ns/iter (± 192717) 41903676 ns/iter (± 349552) 1.00
html/minify/document/github 17380697 ns/iter (± 44650) 17322128 ns/iter (± 79504) 1.00
html/minify/document/stackoverflow 15601834 ns/iter (± 82686) 15468544 ns/iter (± 60516) 1.01
html/minify/document_fragment/css_spec 40701018 ns/iter (± 429905) 39603679 ns/iter (± 273534) 1.03
html/minify/document_fragment/github 16691890 ns/iter (± 35938) 16523652 ns/iter (± 18846) 1.01
html/minify/document_fragment/stackoverflow 15188422 ns/iter (± 43769) 15032097 ns/iter (± 19797) 1.01
html/document/visitor/compare/clone 341420 ns/iter (± 2550) 341262 ns/iter (± 2210) 1.00
html/document/visitor/compare/visit_mut_span 361730 ns/iter (± 1698) 366144 ns/iter (± 1640) 0.99
html/document/visitor/compare/visit_mut_span_panic 376280 ns/iter (± 2204) 373841 ns/iter (± 1729) 1.01
html/document/visitor/compare/fold_span 404075 ns/iter (± 3179) 404389 ns/iter (± 2641) 1.00
html/document/visitor/compare/fold_span_panic 457693 ns/iter (± 1753) 460579 ns/iter (± 2261) 0.99
html/document_fragment/visitor/compare/clone 335057 ns/iter (± 1023) 337681 ns/iter (± 1474) 0.99
html/document_fragment/visitor/compare/visit_mut_span 367596 ns/iter (± 2687) 364036 ns/iter (± 1544) 1.01
html/document_fragment/visitor/compare/visit_mut_span_panic 370421 ns/iter (± 2412) 375630 ns/iter (± 2573) 0.99
html/document_fragment/visitor/compare/fold_span 402347 ns/iter (± 1918) 400033 ns/iter (± 1822) 1.01
html/document_fragment/visitor/compare/fold_span_panic 457712 ns/iter (± 1646) 457386 ns/iter (± 2160) 1.00
html/lexer/css_2021_spec 15491829 ns/iter (± 18325) 15570473 ns/iter (± 15561) 0.99
html/lexer/github_com_17_05_2022 6013586 ns/iter (± 1489) 6031967 ns/iter (± 5063) 1.00
html/lexer/stackoverflow_com_17_05_2022 5626511 ns/iter (± 2467) 5648224 ns/iter (± 6172) 1.00
html/parser/parser_document/css_2021_spec 26210743 ns/iter (± 165765) 25549753 ns/iter (± 276213) 1.03
html/parser/parser_document/github_com_17_05_2022 8756299 ns/iter (± 13751) 8718790 ns/iter (± 3774) 1.00
html/parser/parser_document/stackoverflow_com_17_05_2022 7701276 ns/iter (± 8578) 7684416 ns/iter (± 7028) 1.00
html/parser/parser_document_fragment/css_2021_spec 26335131 ns/iter (± 190018) 25635840 ns/iter (± 171521) 1.03
html/parser/parser_document_fragment/github_com_17_05_2022 8742008 ns/iter (± 7330) 8737548 ns/iter (± 5565) 1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7696664 ns/iter (± 7116) 7684078 ns/iter (± 7170) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.