Skip to content

Commit

Permalink
fix(ci): Fix publish action for binaries (#6517)
Browse files Browse the repository at this point in the history
  • Loading branch information
kwonoj committed Nov 27, 2022
1 parent c82c65c commit 2ac3201
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
3 changes: 3 additions & 0 deletions scripts/cli_artifacts.sh
@@ -1,5 +1,6 @@
#!/bin/sh

mkdir -p artifacts_cli
# Naive substitution to napi artifacts for the cli binary.
for filename in artifacts/*/*.node
do
Expand All @@ -9,8 +10,10 @@ do

if [ -f "$CLI_BINARY_PATH" ]; then
chmod +x $CLI_BINARY_PATH
cp $CLI_BINARY_PATH artifacts_cli/$BINDING_ABI
mv $CLI_BINARY_PATH ./scripts/npm/$BINDING_ABI
elif [ -f "$CLI_BINARY_PATH.exe" ]; then
cp $CLI_BINARY_PATH.exe artifacts_cli/$BINDING_ABI
mv $CLI_BINARY_PATH.exe ./scripts/npm/$BINDING_ABI
fi
done
8 changes: 5 additions & 3 deletions scripts/cli_upload_gh_release.sh
@@ -1,16 +1,18 @@
#!/bin/sh

# Naive substitution to napi artifacts for the cli binary.
for filename in artifacts/*/*.node
for filename in artifacts_cli/*/*
do
echo "Trying to upload $filename"

BINDING_NAME=${filename#*.}
BINDING_ABI=${BINDING_NAME%%.*}
CLI_BINARY_PATH=${filename%%.*}

if [ -f "$CLI_BINARY_PATH" ]; then
chmod +x $CLI_BINARY_PATH
gh release upload $RELEASE_VERSION ./scripts/npm/$BINDING_ABI/$CLI_BINARY_PATH
gh release upload $RELEASE_VERSION $CLI_BINARY_PATH
elif [ -f "$CLI_BINARY_PATH.exe" ]; then
gh release upload $RELEASE_VERSION ./scripts/npm/$BINDING_ABI/$CLI_BINARY_PATH/$CLI_BINARY_PATH.exe
gh release upload $RELEASE_VERSION $CLI_BINARY_PATH.exe
fi
done

1 comment on commit 2ac3201

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 2ac3201 Previous: 0cee0e1 Ratio
es/full/bugs-1 337018 ns/iter (± 23821) 367788 ns/iter (± 29103) 0.92
es/full/minify/libraries/antd 1824084094 ns/iter (± 28162162) 2047450639 ns/iter (± 32932806) 0.89
es/full/minify/libraries/d3 396307461 ns/iter (± 12007412) 485082895 ns/iter (± 32764624) 0.82
es/full/minify/libraries/echarts 1536350144 ns/iter (± 13331888) 1751762329 ns/iter (± 53742056) 0.88
es/full/minify/libraries/jquery 100956948 ns/iter (± 1977683) 122134557 ns/iter (± 11173785) 0.83
es/full/minify/libraries/lodash 117639679 ns/iter (± 19394211) 127727864 ns/iter (± 2359898) 0.92
es/full/minify/libraries/moment 58583824 ns/iter (± 2582839) 66310305 ns/iter (± 3318850) 0.88
es/full/minify/libraries/react 20068648 ns/iter (± 867257) 23068973 ns/iter (± 4802468) 0.87
es/full/minify/libraries/terser 305282895 ns/iter (± 3544236) 343402070 ns/iter (± 19422170) 0.89
es/full/minify/libraries/three 556559468 ns/iter (± 6128636) 610517853 ns/iter (± 18435679) 0.91
es/full/minify/libraries/typescript 3325218072 ns/iter (± 20010761) 3668439590 ns/iter (± 92737404) 0.91
es/full/minify/libraries/victory 816887277 ns/iter (± 14351326) 895860038 ns/iter (± 71837733) 0.91
es/full/minify/libraries/vue 152821610 ns/iter (± 5630053) 186598305 ns/iter (± 10187949) 0.82
es/full/codegen/es3 33263 ns/iter (± 610) 34412 ns/iter (± 2810) 0.97
es/full/codegen/es5 33158 ns/iter (± 1004) 34244 ns/iter (± 1911) 0.97
es/full/codegen/es2015 33154 ns/iter (± 890) 34835 ns/iter (± 1631) 0.95
es/full/codegen/es2016 33118 ns/iter (± 955) 34518 ns/iter (± 2166) 0.96
es/full/codegen/es2017 32854 ns/iter (± 600) 33616 ns/iter (± 1068) 0.98
es/full/codegen/es2018 32939 ns/iter (± 712) 33515 ns/iter (± 967) 0.98
es/full/codegen/es2019 33316 ns/iter (± 528) 33665 ns/iter (± 2069) 0.99
es/full/codegen/es2020 33335 ns/iter (± 766) 34231 ns/iter (± 1384) 0.97
es/full/all/es3 190439322 ns/iter (± 8107839) 197666358 ns/iter (± 11084664) 0.96
es/full/all/es5 177925453 ns/iter (± 9629130) 186210674 ns/iter (± 16652218) 0.96
es/full/all/es2015 144536380 ns/iter (± 4351403) 149786790 ns/iter (± 9167233) 0.96
es/full/all/es2016 141626691 ns/iter (± 6975781) 152026746 ns/iter (± 10212536) 0.93
es/full/all/es2017 140556031 ns/iter (± 3754263) 149578096 ns/iter (± 11225753) 0.94
es/full/all/es2018 139442423 ns/iter (± 4505917) 152730868 ns/iter (± 91797279) 0.91
es/full/all/es2019 134672321 ns/iter (± 4159596) 143747527 ns/iter (± 9268309) 0.94
es/full/all/es2020 129296340 ns/iter (± 3534621) 134960934 ns/iter (± 6861339) 0.96
es/full/parser 678055 ns/iter (± 46982) 731489 ns/iter (± 61108) 0.93
es/full/base/fixer 25372 ns/iter (± 332) 26218 ns/iter (± 1630) 0.97
es/full/base/resolver_and_hygiene 88556 ns/iter (± 1928) 93461 ns/iter (± 10073) 0.95
serialization of ast node 217 ns/iter (± 5) 206 ns/iter (± 14) 1.05
serialization of serde 222 ns/iter (± 7) 217 ns/iter (± 18) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.