Skip to content

Commit

Permalink
feat(css/parser): Normalize and improve function name (#6667)
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexander-akait
alexander-akait committed Dec 20, 2022
1 parent 65c2ab3 commit 2571070
Show file tree
Hide file tree
Showing 53 changed files with 1,479 additions and 749 deletions.
2 changes: 1 addition & 1 deletion crates/jsdoc/tests/fixtures/constanttag.debug
View file
Expand Up @@ -42,7 +42,7 @@
),
ctxt: #0,
},
value: Atom('constant' type=dynamic),
value: Atom('constant' type=static),
},
tag: Const(
ConstTag {
Expand Down
Empty file modified crates/swc_atoms/scripts/add-from-cargo-check.sh 100644 → 100755
View file
Empty file.

1 comment on commit 2571070

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 2571070 Previous: 8a71dbc Ratio
es/full/bugs-1 301411 ns/iter (± 7185) 296009 ns/iter (± 9688) 1.02
es/full/minify/libraries/antd 1637144156 ns/iter (± 23189653) 1550074487 ns/iter (± 30903133) 1.06
es/full/minify/libraries/d3 310079743 ns/iter (± 7288822) 294480995 ns/iter (± 6830163) 1.05
es/full/minify/libraries/echarts 1267229402 ns/iter (± 16589257) 1220225903 ns/iter (± 25991173) 1.04
es/full/minify/libraries/jquery 91641353 ns/iter (± 648899) 88936937 ns/iter (± 593135) 1.03
es/full/minify/libraries/lodash 106197317 ns/iter (± 688802) 103154909 ns/iter (± 823822) 1.03
es/full/minify/libraries/moment 52809441 ns/iter (± 553907) 51759934 ns/iter (± 258737) 1.02
es/full/minify/libraries/react 19011488 ns/iter (± 79458) 18825120 ns/iter (± 102557) 1.01
es/full/minify/libraries/terser 253895576 ns/iter (± 4297845) 238280888 ns/iter (± 1758664) 1.07
es/full/minify/libraries/three 454687258 ns/iter (± 12214190) 419852769 ns/iter (± 5107930) 1.08
es/full/minify/libraries/typescript 3049840379 ns/iter (± 20471614) 2982356243 ns/iter (± 15000918) 1.02
es/full/minify/libraries/victory 696186564 ns/iter (± 8182181) 658806142 ns/iter (± 12071613) 1.06
es/full/minify/libraries/vue 133826662 ns/iter (± 1115535) 128046909 ns/iter (± 581568) 1.05
es/full/codegen/es3 27085 ns/iter (± 48) 27166 ns/iter (± 34) 1.00
es/full/codegen/es5 27070 ns/iter (± 41) 27238 ns/iter (± 48) 0.99
es/full/codegen/es2015 27084 ns/iter (± 35) 27175 ns/iter (± 57) 1.00
es/full/codegen/es2016 27018 ns/iter (± 41) 27166 ns/iter (± 146) 0.99
es/full/codegen/es2017 27111 ns/iter (± 57) 27194 ns/iter (± 68) 1.00
es/full/codegen/es2018 27081 ns/iter (± 55) 27155 ns/iter (± 63) 1.00
es/full/codegen/es2019 27055 ns/iter (± 46) 27148 ns/iter (± 52) 1.00
es/full/codegen/es2020 27080 ns/iter (± 149) 27182 ns/iter (± 43) 1.00
es/full/all/es3 164865311 ns/iter (± 3031385) 167912417 ns/iter (± 2371844) 0.98
es/full/all/es5 158082715 ns/iter (± 3695467) 161248110 ns/iter (± 3810040) 0.98
es/full/all/es2015 118736026 ns/iter (± 761425) 119291090 ns/iter (± 929175) 1.00
es/full/all/es2016 118065636 ns/iter (± 528273) 118496028 ns/iter (± 706279) 1.00
es/full/all/es2017 118046030 ns/iter (± 431151) 117442617 ns/iter (± 504494) 1.01
es/full/all/es2018 116069265 ns/iter (± 867227) 115868519 ns/iter (± 972017) 1.00
es/full/all/es2019 115849653 ns/iter (± 776109) 115063887 ns/iter (± 550625) 1.01
es/full/all/es2020 110950923 ns/iter (± 428584) 110552097 ns/iter (± 619903) 1.00
es/full/parser 508977 ns/iter (± 8401) 515951 ns/iter (± 8484) 0.99
es/full/base/fixer 21804 ns/iter (± 20) 21635 ns/iter (± 48) 1.01
es/full/base/resolver_and_hygiene 77759 ns/iter (± 120) 77391 ns/iter (± 101) 1.00
serialization of ast node 118 ns/iter (± 0) 118 ns/iter (± 0) 1
serialization of serde 123 ns/iter (± 0) 123 ns/iter (± 0) 1
css/minify/libraries/bootstrap 28034627 ns/iter (± 108789) 26678474 ns/iter (± 108540) 1.05
css/visitor/compare/clone 2064706 ns/iter (± 21057) 2074881 ns/iter (± 11490) 1.00
css/visitor/compare/visit_mut_span 2251708 ns/iter (± 14475) 2260598 ns/iter (± 4033) 1.00
css/visitor/compare/visit_mut_span_panic 2315925 ns/iter (± 10700) 2317785 ns/iter (± 4200) 1.00
css/visitor/compare/fold_span 3061903 ns/iter (± 10726) 2989185 ns/iter (± 14367) 1.02
css/visitor/compare/fold_span_panic 3211086 ns/iter (± 18048) 3132315 ns/iter (± 20539) 1.03
css/lexer/bootstrap_5_1_3 5178960 ns/iter (± 1113) 5196998 ns/iter (± 25941) 1.00
css/lexer/foundation_6_7_4 4399467 ns/iter (± 3576) 4374919 ns/iter (± 1010) 1.01
css/lexer/tailwind_3_1_1 832360 ns/iter (± 354) 829291 ns/iter (± 2655) 1.00
css/parser/bootstrap_5_1_3 21683191 ns/iter (± 161335) 20760318 ns/iter (± 39158) 1.04
css/parser/foundation_6_7_4 17280106 ns/iter (± 82355) 16552681 ns/iter (± 39276) 1.04
css/parser/tailwind_3_1_1 3305406 ns/iter (± 15596) 3213343 ns/iter (± 4081) 1.03
es/codegen/colors 331391 ns/iter (± 186052) 332511 ns/iter (± 186951) 1.00
es/codegen/large 1232013 ns/iter (± 626029) 1215816 ns/iter (± 645803) 1.01
es/codegen/with-parser/colors 46762 ns/iter (± 100) 46072 ns/iter (± 247) 1.01
es/codegen/with-parser/large 517030 ns/iter (± 2011) 520287 ns/iter (± 1059) 0.99
es/minify/libraries/antd 1451329214 ns/iter (± 11684858) 1407570132 ns/iter (± 27348330) 1.03
es/minify/libraries/d3 268009066 ns/iter (± 3700794) 245948047 ns/iter (± 2936579) 1.09
es/minify/libraries/echarts 1102931928 ns/iter (± 10556861) 1034985452 ns/iter (± 10637547) 1.07
es/minify/libraries/jquery 79613348 ns/iter (± 1018151) 77182351 ns/iter (± 405657) 1.03
es/minify/libraries/lodash 97299027 ns/iter (± 1614362) 93662191 ns/iter (± 812467) 1.04
es/minify/libraries/moment 46263245 ns/iter (± 163949) 45220053 ns/iter (± 193395) 1.02
es/minify/libraries/react 17002319 ns/iter (± 135339) 16889464 ns/iter (± 31639) 1.01
es/minify/libraries/terser 218018320 ns/iter (± 2403133) 204913389 ns/iter (± 1056877) 1.06
es/minify/libraries/three 387104933 ns/iter (± 11080954) 350525289 ns/iter (± 2394486) 1.10
es/minify/libraries/typescript 2640007430 ns/iter (± 13257742) 2569645196 ns/iter (± 13006743) 1.03
es/minify/libraries/victory 608442530 ns/iter (± 10744225) 553271554 ns/iter (± 17791263) 1.10
es/minify/libraries/vue 119053315 ns/iter (± 1426116) 114527466 ns/iter (± 1003804) 1.04
es/visitor/compare/clone 2402248 ns/iter (± 20426) 2444324 ns/iter (± 2237) 0.98
es/visitor/compare/visit_mut_span 2800736 ns/iter (± 19021) 2822410 ns/iter (± 4885) 0.99
es/visitor/compare/visit_mut_span_panic 2862732 ns/iter (± 9760) 2867840 ns/iter (± 9025) 1.00
es/visitor/compare/fold_span 3879797 ns/iter (± 20733) 3968438 ns/iter (± 6875) 0.98
es/visitor/compare/fold_span_panic 4062147 ns/iter (± 16148) 4122857 ns/iter (± 8529) 0.99
es/lexer/colors 17117 ns/iter (± 6) 17235 ns/iter (± 661) 0.99
es/lexer/angular 8181569 ns/iter (± 2057) 8179199 ns/iter (± 21653) 1.00
es/lexer/backbone 1066416 ns/iter (± 478) 1069031 ns/iter (± 605) 1.00
es/lexer/jquery 5913143 ns/iter (± 1953) 5922926 ns/iter (± 5058) 1.00
es/lexer/jquery mobile 9118869 ns/iter (± 5747) 9114794 ns/iter (± 5302) 1.00
es/lexer/mootools 4635222 ns/iter (± 1238) 4646151 ns/iter (± 2911) 1.00
es/lexer/underscore 889847 ns/iter (± 476) 894829 ns/iter (± 807) 0.99
es/lexer/three 27629936 ns/iter (± 16403) 27588029 ns/iter (± 8367) 1.00
es/lexer/yui 5012083 ns/iter (± 1580) 5018541 ns/iter (± 4401) 1.00
es/parser/colors 31337 ns/iter (± 174) 30779 ns/iter (± 815) 1.02
es/parser/angular 16362893 ns/iter (± 273033) 15345108 ns/iter (± 148213) 1.07
es/parser/backbone 2347080 ns/iter (± 39898) 2297795 ns/iter (± 13812) 1.02
es/parser/jquery 12743426 ns/iter (± 154880) 12376975 ns/iter (± 78408) 1.03
es/parser/jquery mobile 20649269 ns/iter (± 359123) 19472202 ns/iter (± 112154) 1.06
es/parser/mootools 9717071 ns/iter (± 98323) 9520029 ns/iter (± 18346) 1.02
es/parser/underscore 1992695 ns/iter (± 10064) 1952806 ns/iter (± 10803) 1.02
es/parser/three 60498469 ns/iter (± 304034) 56563026 ns/iter (± 566886) 1.07
es/parser/yui 9741463 ns/iter (± 119748) 9526483 ns/iter (± 59166) 1.02
es/preset-env/usage/builtin_type 140997 ns/iter (± 32050) 142519 ns/iter (± 32441) 0.99
es/preset-env/usage/property 21472 ns/iter (± 86) 21730 ns/iter (± 96) 0.99
es/resolver/typescript 111104242 ns/iter (± 2925258) 109135959 ns/iter (± 998312) 1.02
es/fixer/typescript 88573116 ns/iter (± 702193) 87711144 ns/iter (± 1647997) 1.01
es/hygiene/typescript 171622221 ns/iter (± 1181986) 167065810 ns/iter (± 1247144) 1.03
es/resolver_with_hygiene/typescript 316513766 ns/iter (± 1868940) 290452897 ns/iter (± 1407795) 1.09
es/visitor/base-perf/module_clone 74883 ns/iter (± 2081) 76370 ns/iter (± 1838) 0.98
es/visitor/base-perf/fold_empty 85694 ns/iter (± 2379) 87521 ns/iter (± 1169) 0.98
es/visitor/base-perf/fold_noop_impl_all 85191 ns/iter (± 1672) 86760 ns/iter (± 1395) 0.98
es/visitor/base-perf/fold_noop_impl_vec 85167 ns/iter (± 1536) 87412 ns/iter (± 1305) 0.97
es/visitor/base-perf/boxing_boxed_clone 59 ns/iter (± 0) 55 ns/iter (± 0) 1.07
es/visitor/base-perf/boxing_unboxed_clone 60 ns/iter (± 0) 58 ns/iter (± 0) 1.03
es/visitor/base-perf/boxing_boxed 106 ns/iter (± 0) 99 ns/iter (± 0) 1.07
es/visitor/base-perf/boxing_unboxed 102 ns/iter (± 0) 99 ns/iter (± 0) 1.03
es/visitor/base-perf/visit_contains_this 3525 ns/iter (± 130) 3616 ns/iter (± 54) 0.97
es/base/parallel/resolver/typescript 5066440512 ns/iter (± 468196707) 5543448949 ns/iter (± 509032370) 0.91
es/base/parallel/hygiene/typescript 2015079794 ns/iter (± 38948046) 2019930662 ns/iter (± 37386771) 1.00
misc/visitors/time-complexity/time 5 93 ns/iter (± 0) 102 ns/iter (± 0) 0.91
misc/visitors/time-complexity/time 10 293 ns/iter (± 3) 316 ns/iter (± 0) 0.93
misc/visitors/time-complexity/time 15 601 ns/iter (± 2) 647 ns/iter (± 0) 0.93
misc/visitors/time-complexity/time 20 1143 ns/iter (± 20) 1233 ns/iter (± 3) 0.93
misc/visitors/time-complexity/time 40 5958 ns/iter (± 22) 6698 ns/iter (± 74) 0.89
misc/visitors/time-complexity/time 60 15189 ns/iter (± 54) 17075 ns/iter (± 46) 0.89
es/full-target/es2016 188238 ns/iter (± 537) 189346 ns/iter (± 456) 0.99
es/full-target/es2017 183779 ns/iter (± 337) 183401 ns/iter (± 543) 1.00
es/full-target/es2018 172435 ns/iter (± 265) 173680 ns/iter (± 390) 0.99
es2020_nullish_coalescing 66939 ns/iter (± 206) 67125 ns/iter (± 104) 1.00
es2020_optional_chaining 95922 ns/iter (± 317) 96515 ns/iter (± 7178) 0.99
es2022_class_properties 94420 ns/iter (± 328) 94468 ns/iter (± 116) 1.00
es2018_object_rest_spread 70862 ns/iter (± 303) 71879 ns/iter (± 195) 0.99
es2019_optional_catch_binding 61198 ns/iter (± 72) 61509 ns/iter (± 124) 0.99
es2017_async_to_generator 61649 ns/iter (± 89) 61702 ns/iter (± 90) 1.00
es2016_exponentiation 64611 ns/iter (± 97) 65384 ns/iter (± 533) 0.99
es2015_arrow 70068 ns/iter (± 324) 70758 ns/iter (± 221) 0.99
es2015_block_scoped_fn 66022 ns/iter (± 308) 66541 ns/iter (± 790) 0.99
es2015_block_scoping 139198 ns/iter (± 7572) 143399 ns/iter (± 6564) 0.97
es2015_classes 116079 ns/iter (± 325) 116473 ns/iter (± 431) 1.00
es2015_computed_props 60465 ns/iter (± 169) 61357 ns/iter (± 113) 0.99
es2015_destructuring 115164 ns/iter (± 204) 116099 ns/iter (± 1157) 0.99
es2015_duplicate_keys 62298 ns/iter (± 90) 64368 ns/iter (± 107) 0.97
es2015_parameters 77691 ns/iter (± 117) 79796 ns/iter (± 154) 0.97
es2015_fn_name 65354 ns/iter (± 561) 66538 ns/iter (± 344) 0.98
es2015_for_of 63250 ns/iter (± 80) 64622 ns/iter (± 131) 0.98
es2015_instanceof 61606 ns/iter (± 56) 63559 ns/iter (± 118) 0.97
es2015_shorthand_property 59780 ns/iter (± 65) 61203 ns/iter (± 153) 0.98
es2015_spread 59695 ns/iter (± 119) 61335 ns/iter (± 80) 0.97
es2015_sticky_regex 60661 ns/iter (± 95) 62452 ns/iter (± 131) 0.97
es2015_typeof_symbol 60689 ns/iter (± 77) 62516 ns/iter (± 116) 0.97
es/transform/baseline/base 50635 ns/iter (± 106) 52163 ns/iter (± 100) 0.97
es/transform/baseline/common_reserved_word 61343 ns/iter (± 59) 62519 ns/iter (± 98) 0.98
es/transform/baseline/common_typescript 139515 ns/iter (± 125) 142230 ns/iter (± 324) 0.98
es/target/es3 167579 ns/iter (± 426) 171278 ns/iter (± 323) 0.98
es/target/es2015 605564 ns/iter (± 1205) 630941 ns/iter (± 952) 0.96
es/target/es2016 63549 ns/iter (± 67) 65300 ns/iter (± 112) 0.97
es/target/es2017 60462 ns/iter (± 81) 61838 ns/iter (± 124) 0.98
es/target/es2018 79627 ns/iter (± 72) 82008 ns/iter (± 345) 0.97
es/target/es2020 129776 ns/iter (± 169) 134151 ns/iter (± 230) 0.97
babelify-only 672143 ns/iter (± 1002) 674849 ns/iter (± 902) 1.00
parse_and_babelify_angular 46577191 ns/iter (± 1008935) 43689509 ns/iter (± 955857) 1.07
parse_and_babelify_backbone 5636753 ns/iter (± 54103) 5322263 ns/iter (± 46985) 1.06
parse_and_babelify_jquery 34021817 ns/iter (± 372256) 31843532 ns/iter (± 459217) 1.07
parse_and_babelify_jquery_mobile 57950839 ns/iter (± 821186) 53361854 ns/iter (± 794059) 1.09
parse_and_babelify_mootools 34660526 ns/iter (± 395550) 31964122 ns/iter (± 317107) 1.08
parse_and_babelify_underscore 4419936 ns/iter (± 30173) 4336092 ns/iter (± 46747) 1.02
parse_and_babelify_yui 34051461 ns/iter (± 663609) 31734911 ns/iter (± 857401) 1.07
html/minify/document/css_spec 44126463 ns/iter (± 257590) 41653100 ns/iter (± 930600) 1.06
html/minify/document/github 17777811 ns/iter (± 40925) 17642051 ns/iter (± 59255) 1.01
html/minify/document/stackoverflow 16075360 ns/iter (± 87032) 15752331 ns/iter (± 152876) 1.02
html/minify/document_fragment/css_spec 42844950 ns/iter (± 144115) 39762220 ns/iter (± 575047) 1.08
html/minify/document_fragment/github 17007236 ns/iter (± 67376) 16608438 ns/iter (± 35970) 1.02
html/minify/document_fragment/stackoverflow 15540712 ns/iter (± 71566) 15057967 ns/iter (± 65928) 1.03
html/document/visitor/compare/clone 344068 ns/iter (± 1882) 340638 ns/iter (± 3016) 1.01
html/document/visitor/compare/visit_mut_span 367961 ns/iter (± 2133) 365206 ns/iter (± 1551) 1.01
html/document/visitor/compare/visit_mut_span_panic 375749 ns/iter (± 2594) 374023 ns/iter (± 1468) 1.00
html/document/visitor/compare/fold_span 407964 ns/iter (± 1606) 407474 ns/iter (± 1786) 1.00
html/document/visitor/compare/fold_span_panic 462644 ns/iter (± 1508) 464554 ns/iter (± 2549) 1.00
html/document_fragment/visitor/compare/clone 341122 ns/iter (± 2595) 340670 ns/iter (± 2895) 1.00
html/document_fragment/visitor/compare/visit_mut_span 366939 ns/iter (± 2016) 366820 ns/iter (± 2585) 1.00
html/document_fragment/visitor/compare/visit_mut_span_panic 376854 ns/iter (± 1543) 377051 ns/iter (± 2029) 1.00
html/document_fragment/visitor/compare/fold_span 407707 ns/iter (± 3221) 400977 ns/iter (± 2106) 1.02
html/document_fragment/visitor/compare/fold_span_panic 458813 ns/iter (± 2883) 463315 ns/iter (± 1530) 0.99
html/lexer/css_2021_spec 15613306 ns/iter (± 15955) 15590174 ns/iter (± 13901) 1.00
html/lexer/github_com_17_05_2022 6028508 ns/iter (± 1868) 6047762 ns/iter (± 4267) 1.00
html/lexer/stackoverflow_com_17_05_2022 5648355 ns/iter (± 1550) 5665546 ns/iter (± 2931) 1.00
html/parser/parser_document/css_2021_spec 27018558 ns/iter (± 362553) 26071512 ns/iter (± 201516) 1.04
html/parser/parser_document/github_com_17_05_2022 8839722 ns/iter (± 16147) 8779611 ns/iter (± 12632) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7809014 ns/iter (± 17336) 7790186 ns/iter (± 8763) 1.00
html/parser/parser_document_fragment/css_2021_spec 27405288 ns/iter (± 248810) 26976795 ns/iter (± 577424) 1.02
html/parser/parser_document_fragment/github_com_17_05_2022 8844299 ns/iter (± 13187) 8792127 ns/iter (± 142783) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7805097 ns/iter (± 12194) 7790887 ns/iter (± 5059) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.