Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deps fix #685

Merged
merged 3 commits into from Feb 7, 2023
Merged

Deps fix #685

merged 3 commits into from Feb 7, 2023

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Feb 7, 2023 •
edited

@Brooooooklyn Brooooooklyn merged commit f711e51 into master Feb 7, 2023
@Brooooooklyn Brooooooklyn deleted the deps-fix branch February 7, 2023 07:46
stefee
stefee reviewed Feb 7, 2023
View reviewed changes
packages/register/read-default-tsconfig.ts
swc: {
filename,
jsc: {
externalHelpers: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this void the change from #673 - this was added to resolve an issue with our test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefee stefee stefee left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@swc-node/jest needs install @swc/helpers ? @swc-node/jest ReferenceError: React is not defined
2 participants
@Brooooooklyn @stefee