Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate route order #994

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nazoking
Copy link

Describe the PR

#968 fixes the priority of duplicate routes in alphabetical order in the file path.
But that is not the priority we need in the field.

  1. If more than one is specified in the -dir option, give priority to the directory at the beginning of the option.
  2. Prioritize the source of the dependency over the library of the dependency.

Our project consists of creating a new site by referring to the source of common parts.

In many cases, we believe that this priority specification will work as ideal.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #994 (5c5431c) into master (523e046) will increase coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   92.57%   92.58%   +0.01%     
==========================================
  Files           8        8              
  Lines        1925     1928       +3     
==========================================
+ Hits         1782     1785       +3     
  Misses         80       80              
  Partials       63       63              
Impacted Files Coverage Δ
types.go 100.00% <ø> (ø)
parser.go 92.56% <84.61%> (+<0.01%) ⬆️
packages.go 77.85% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e046...5c5431c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant