Handle case of empty GOROOT #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, such as when using the go-swag Nix package, runtime.GOROOT() will be empty, and RangeFiles will skip all source paths since technically, all paths are prefixed with the empty string. See also NixOS/nixpkgs#224701 May resolve some cases of swaggo#1622.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 83.40% 81.70% -1.71%
==========================================
Files 16 17 +1
Lines 3881 3962 +81
==========================================
Hits 3237 3237
- Misses 545 626 +81
Partials 99 99 ☔ View full report in Codecov by Sentry. |
ubogdan
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
In some situations, such as when using the go-swag Nix package,
runtime.GOROOT()will be empty, andRangeFileswill skip all source paths since technically, all paths are prefixed with the empty string.See also NixOS/nixpkgs#224701
May resolve some cases of #1622.
Relation issue
NixOS/nixpkgs#224701
#1622
Additional context