Feat: allow enum ordered const name override #1779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubogdan
requested changes
Apr 21, 2024
const.go
Outdated
| func (cv *ConstVariable) VariableName() string { | ||
| if ignoreNameOverride(cv.Name.Name) { | ||
| return cv.Name.Name[1:] | ||
| } else if overriddenName := nameOverride(cv.Comment); overriddenName != "" { |
There was a problem hiding this comment.
prease remove the useless else for better reading
types.go
Outdated
| return texts[1] | ||
| } | ||
| } | ||
| } else if overriddenName := nameOverride(t.TypeSpec.Comment); overriddenName != "" { |
|
@drewsilcock Please rebase and update the code. |
drewsilcock
force-pushed
the
feature/allow-enum-ordered-const-name-override
branch
from
1443dbf
to
61ef538
Compare
|
Thanks for taking the time to take a look at this @ubogdan - I've rebased and updated based on the linter and your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add ability to override name of enum variant generated from ordered constant using
// @name VariantNamein the same way you can do for types.Relation issue
#1778
Additional context
N/A