Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1742 #1744

Merged
merged 3 commits into from Jan 22, 2024
Merged

fix #1742 #1744

merged 3 commits into from Jan 22, 2024

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jan 17, 2024

Describe the PR
fix #1742

Relation issue
#1742

Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76695ca) 83.25% compared to head (efb30fe) 83.26%.

Files Patch % Lines
packages.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1744   +/-   ##
=======================================
  Coverage   83.25%   83.26%           
=======================================
  Files          16       16           
  Lines        3811     3813    +2     
=======================================
+ Hits         3173     3175    +2     
  Misses        542      542           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan January 17, 2024 03:42
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit ae7e404 into master Jan 22, 2024
12 checks passed
@sdghchj sdghchj deleted the fix_1742 branch January 22, 2024 01:29
@ngehrsitz
Copy link
Contributor

@sdghchj Can you please release a new version? v1.16.2 is already a few months old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swag init does not properly generate @scope annotations
3 participants