Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update modules #1715

Closed

Conversation

jvilhuber
Copy link

Describe the PR

Update modules (go get -u ./...; go mod tidy; make) to make security scanners happy.

Relation issue

Additional context

@sdghchj
Copy link
Member

sdghchj commented Dec 18, 2023

strings.Cut from higher go version failed in go v.17.
@ubogdan Give up this upgrade or give up go v1.17?

@ubogdan
Copy link
Contributor

ubogdan commented Dec 18, 2023

Yes , please update the gihub action and Readme . remove 1.17 and as 1.21

@sdghchj
Copy link
Member

sdghchj commented Dec 18, 2023

@jvilhuber Hello, rebase your branch on the latest master, please.

@jvilhuber
Copy link
Author

pulled in latest changes and ran go get -u ./...; go mod tidy one more time (to pick up any changes due to upgrade from go 1.17 to go 1.18 in the base).

@sdghchj
Copy link
Member

sdghchj commented Jan 2, 2024

@jvilhuber Sorry, my fault to bother you to rebase again.

Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package github.com/go-openapi/spec@v0.20.13 needs go1.19 at least, not compatibale with go1.18

@jvilhuber jvilhuber closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants