Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting crosstalk #1317

Merged
merged 3 commits into from Sep 6, 2022

Commits on Sep 4, 2022

  1. Copy the full SHA
    73886d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Formatter: model changes as byte-range edits.

    The previous find-and-replace technique for replacing comment lines with
    their formatted counterparts could apply the change to the wrong line,
    when multiple identical comment lines exited. This led to “crosstalk”: a
    formatting change to a comment on one function being applied to another,
    unrelated function. By modeling each desired replacement with the byte
    range that it specifically applies to, replacements are now always made
    to the desired location.
    MrDOS committed Sep 5, 2022
    Copy the full SHA
    606925f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Copy the full SHA
    21e660d View commit details
    Browse the repository at this point in the history