Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test host && make combined object definition can based on interface{} && add one more tips #1261

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

extrame
Copy link

@extrame extrame commented Jul 12, 2022

Describe the PR

  1. test host definition
  2. give more information if param type is wrong
  3. make combined object definition can defined based on interface{} like:
    " @success 200 {object} {success=bool}"

Relation issue
none

Additional context
none

@extrame extrame changed the title Test host Test host && make combined object definition can based on interface{} && add one more tips Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1261 (66b6f9e) into master (bd21bb0) will decrease coverage by 0.29%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
- Coverage   94.99%   94.69%   -0.30%     
==========================================
  Files          14       14              
  Lines        2618     2622       +4     
==========================================
- Hits         2487     2483       -4     
- Misses         72       76       +4     
- Partials       59       63       +4     
Impacted Files Coverage Δ
parser.go 93.37% <0.00%> (-0.23%) ⬇️
operation.go 96.38% <33.33%> (-0.28%) ⬇️
generics.go 91.04% <0.00%> (-2.99%) ⬇️
packages.go 87.30% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd21bb0...66b6f9e. Read the comment docs.

@ubogdan
Copy link
Contributor

ubogdan commented Aug 16, 2022

@extrame We expect all the contributions to be based on an open issue and to discuss the directions, so the developer's work wont is in vain.
I want to remind you that OpenApi Documentation (swagger) is about documenting types, not values.

You are documenting the response value for HTTP 200 OK if I understand well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants