Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1) add logrus as logger package, so we can handle more log level #1252

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

extrame
Copy link

@extrame extrame commented Jul 6, 2022

Describe the PR

  1. add logrus as logger package, so we can handle more log level
  2. change parser.debuger to parser.logger, so use it to log other levels make sense.
  3. make more log use logger.trace.
  4. add verbose flag, so user can see more detail of executation( trace level).
  5. allow search unnamed import even if parseDependency is disabled. (reason: unnamed import is used widely; not all dependency need parsed, just need those which is used in comments).

Relation issue
no

Additional context
no

@MrDOS
Copy link
Contributor

MrDOS commented Jul 6, 2022

As a consumer of this library, I'm generally leery of libraries tying themselves to any particular logging library. While most of my applications do depend on Logrus, I'd hate for an application which uses something else – e.g., the standard logger, zap, or Zerolog – to be saddled with a transitive dependency on Logrus.

At the same time, I understand the desire to avail oneself of more structured logging in the swag CLI application. Perhaps the swag CLI could be moved into its own module so that it can depend on Logrus independently of the top-level library?

Liu Ming added 4 commits July 12, 2022 09:39
2)clear the bug of "no logger" in test file
3)clear no-use variables
4)add some information if param type is wrong
2)   make user can define combiled object of interface{}
2) support definition of multi path for single method
@ubogdan ubogdan requested review from sdghchj and removed request for sdghchj December 14, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants