feat: adds basic generics support #1194
Conversation
operation.go
Outdated
| matches[3] += commentLine[allMatchesLenOffset : allMatchesLenOffset+lostPartEndIdx+1] | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This check has to be done inside parseAPIObjectSchema
Lines 981 to 984 in 65ab05e
There was a problem hiding this comment.
it uses the entire commentLine tho. this check could be done, if we would pass it as a parameter, but it's questionable if we want to change the function signature
There was a problem hiding this comment.
The parseAPIObjectSchema is a private method, so we can change the signature when needed.
There was a problem hiding this comment.
ok, I just did it.
another thing to consider is that this PR relies on 1.18 ast.TypeSpec, so it won't work on older versions anymore.
There was a problem hiding this comment.
ok, I just did it.
another thing to consider is that this PR relies on 1.18 ast.TypeSpec, so it won't work on older versions anymore.
Then this is a breaking change and it has to be implemented in v2.
There was a problem hiding this comment.
You might be able to take the same approach as in gopls. Have a look at golangci/golangci-lint#2649 (comment)
There was a problem hiding this comment.
I just added fallback implementations for older Go versions, I think it should do the trick
moves refType checks into parseAPIObjectSchema as per @ubogdan suggestion.
| return typeSpecDef.FullName() | ||
| } | ||
|
|
||
| func (pkgDefs *PackagesDefinitions) parametrizeStruct(original *TypeSpecDef, fullGenericForm string) *TypeSpecDef { |
There was a problem hiding this comment.
How do you expect to pass the tests for older go versions if this is not implemented?
There was a problem hiding this comment.
I guess you will have to put the TestParseGenericsBasic into a separate test file and add build tags.
The typeSpecDef.TypeSpec.TypeParams used in packages.go isn't available in < 1.18, so will have to use the same approach as in
https://github.com/golang/tools/blob/master/internal/typeparams/typeparams_go118.go
https://github.com/golang/tools/blob/master/internal/typeparams/typeparams_go117.go
There was a problem hiding this comment.
There was a problem hiding this comment.
The swag generator must produce the same output no matter if it is built with go1.6 or go1.18.
There was a problem hiding this comment.
@kirillDanshin any update here?
|
@kirillDanshin Thanks for your contribution. |
Describe the PR
This PR adds basic support for 1.18 generics.
It does not support aliases to generics, but it does support single and multi parameter generics.
The approach used in this PR inlines type parameters, so the code around the changed sections could treat these types as if it was defined without type parameters at all.
Relation issue
#1170
Additional context
Additional context provided in the issue linked above.