Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swaggerinfo template for instanceNames #1134

Merged
merged 1 commit into from Feb 10, 2022

Conversation

Syuparn
Copy link
Contributor

@Syuparn Syuparn commented Feb 10, 2022

Describe the PR
e.g. fix template to generate swaggerInfo variable when --instanceName option is specified

Relation issue

#1133

@Syuparn Syuparn changed the title fix: swaggerinfo template for instanceNames (#1133) fix: swaggerinfo template for instanceNames Feb 10, 2022
ubogdan
ubogdan previously approved these changes Feb 10, 2022
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Feb 10, 2022

@Syuparn Would you mind adding a unit test for template rendering output to cover this fix?

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1134 (87a827a) into master (7e207e5) will not change coverage.
The diff coverage is n/a.

❗ Current head 87a827a differs from pull request most recent head 9b56776. Consider uploading reports for the commit 9b56776 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          10       10           
  Lines        2433     2433           
=======================================
  Hits         2305     2305           
  Misses         67       67           
  Partials       61       61           
Impacted Files Coverage Δ
gen/gen.go 93.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e207e5...9b56776. Read the comment docs.

@Syuparn
Copy link
Contributor Author

Syuparn commented Feb 10, 2022

@Syuparn Would you mind adding a unit test for template rendering output to cover this fix?

@ubogdan

I added variable rendering tests.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 1a0a57a into swaggo:master Feb 10, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Feb 10, 2022

@Syuparn Thanks for your contribution

@Syuparn Syuparn deleted the fix-instancename-swaggerinfo branch February 10, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants