Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update go directive in go.mod to 1.17 #1089

Merged
merged 2 commits into from Dec 24, 2021
Merged

build: update go directive in go.mod to 1.17 #1089

merged 2 commits into from Dec 24, 2021

Conversation

Juneezee
Copy link
Contributor

Describe the PR
This PR introduces two changes:

  1. Updates the go directive in go.mod file by running go mod tidy -go=1.17 to enable module graph pruning and lazy module loading.
  2. Update Dockerfile to use the golang:1.17-alpine image

Relation issue

Additional context

Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.

Note 2: The additional require directive is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.

This commit enables support for module graph pruning and lazy module
loading for projects that are at Go 1.17 or higher.

Reference: https://go.dev/ref/mod#go-mod-file-go
Reference: https://go.dev/ref/mod#graph-pruning
Reference: https://go.dev/ref/mod#lazy-loading
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #1089 (6fb0827) into master (a8ef569) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           9        9           
  Lines        2316     2316           
=======================================
  Hits         2188     2188           
  Misses         67       67           
  Partials       61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ef569...6fb0827. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit b0cdfd4 into swaggo:master Dec 24, 2021
@ubogdan
Copy link
Contributor

ubogdan commented Dec 24, 2021

@Juneezee Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants