Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move css and js to seperate files #280

Merged
merged 3 commits into from Sep 7, 2023
Merged

move css and js to seperate files #280

merged 3 commits into from Sep 7, 2023

Conversation

limistah
Copy link
Contributor

@limistah limistah commented Sep 6, 2023

Describe the PR
Moved the CSS and JS into separate template files. And using link and style attributes to pull them via HTTP request
See #249

Relation issue
#249

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cc12e52) 100.00% compared to head (7606ee4) 100.00%.

❗ Current head 7606ee4 differs from pull request most recent head ee5ed54. Consider uploading reports for the commit ee5ed54 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           98       104    +6     
=========================================
+ Hits            98       104    +6     
Files Changed Coverage Δ
swagger.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 3b4340f into swaggo:master Sep 7, 2023
6 checks passed
@ubogdan
Copy link
Contributor

ubogdan commented Sep 7, 2023

@limistah Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants