Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): add support for oneOf/anyOf JSON Schema keywords in parameter-row rendering #9934

Merged
merged 4 commits into from May 14, 2024

Conversation

glowcloud
Copy link
Contributor

Refs #7912

@char0n
Copy link
Member

char0n commented May 14, 2024

Hi @glowcloud,

Could we provide more context to this PR? I've seen the original issue #7912, but I'm missing answers for the following questions:

@glowcloud
Copy link
Contributor Author

The issue is basically the same as #9763 but this one concerns cases where oneOf/anyOf is inside of a parameter instead of a request body. It should be fixed in both places and this PR uses the same logic as in #9767, for getting the correct properties of the parameter and the default value.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is sound. Nice work! Please have a look at my CR comment.

@glowcloud glowcloud merged commit 9037acf into master May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants